Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement DumpRenderTree-like in servo #4731

Closed
Adenilson opened this issue Jan 27, 2015 · 6 comments
Closed

Implement DumpRenderTree-like in servo #4731

Adenilson opened this issue Jan 27, 2015 · 6 comments

Comments

@Adenilson
Copy link
Contributor

@Adenilson Adenilson commented Jan 27, 2015

WebKit/Blink both allow developers to dump the page RenderTree formatted as text using a console. Generally, while debugging rendering/layout bugs, this the first step to be done (i.e. inspect the elements in the render tree).

Speaking with pcwalton, DisplayList should have some code to dump its contents and it should be a matter of having a new CLI option passed to servo to print the tree to console.

This bug is to track implementing this feature.

@metajack
Copy link
Contributor

@metajack metajack commented Jan 27, 2015

Just to be clear, you want a display list dumper, not a flow tree dumper? The latter we already have, but that is what corresponds to Gecko's frame tree and WebKit's render tree as I recall.

@Adenilson
Copy link
Contributor Author

@Adenilson Adenilson commented Jan 27, 2015

@pcwalton: besides DisplayList::all_display_items() any other noteworthy method to the task at hand?

@Adenilson
Copy link
Contributor Author

@Adenilson Adenilson commented Jan 27, 2015

@metajack: yep!

@Adenilson
Copy link
Contributor Author

@Adenilson Adenilson commented Feb 27, 2015

Ok, first step was done on: #5062

What is missing now would be more information (e.g. geometry, etc).

@Adenilson
Copy link
Contributor Author

@Adenilson Adenilson commented Mar 17, 2015

The missing step is implemented on #5209.

@Adenilson
Copy link
Contributor Author

@Adenilson Adenilson commented Mar 18, 2015

As #5209 has landed (and considering that -Z dump-flow-tree is implemented), I think we can close this issue.

@Adenilson Adenilson closed this Mar 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.