Fix warnings about RefCell<T>.try_borrow() #4909
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This method returned the result of `RefCell<T>.try_borrow().is_some()`. But it meant whether the state **is not** BorrowState::Writing. This wrong is introduced by [1], Before it revision, this method had returned whether the state is BorrowState::Writing or not. This doesn't change callers of this method because git blames ([3], [4]) says that the caller is introduced by [2] and [2] is introduced before [1]. [1]: servo@86d609a [2]: servo@4923448 [3]: https://github.com/servo/servo/blame/2cc08f289ab909de44fa09a07b2c43b70ce379b9/components/script/dom/servohtmlparser.rs [4]: https://github.com/servo/servo/blame/a7e29939a1df679bd865573dc71f7ba65f0268c4/components/script/dom/bindings/cell.rs
|
Critic review: https://critic.hoppipolla.co.uk/r/3977 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
tetsuharuohzeki
added
S-awaiting-review
bors-servo
pushed a commit
that referenced
this pull request
Feb 12, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow up #4893