Move selector matching to an external library, for use outside Servo. #5010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Critic review: https://critic.hoppipolla.co.uk/r/4053 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
|
To reviewers: this is mostly moving things around and fixing up The only significant change is that |
SimonSapin
force-pushed
the
external-selectors
branch
from
d5648bc
to
abbc1ef
Compare
bors-servo
pushed a commit
that referenced
this pull request
Feb 23, 2015
The new library is https://github.com/servo/rust-selectors. It’s not quite ready for other users (the API needs work), but this is a first step. servo/rust-selectors#2 should also be reviewed. Fixes #3669.
|
|
Adding this change and squashing: --- a/components/style/stylesheets.rs
+++ b/components/style/stylesheets.rs
@@ -328,7 +328,7 @@ pub fn iter_font_face_rules<F>(stylesheet: &Stylesheet, device: &Device,
fn test_parse_stylesheet() {
use std::sync::Arc;
use cssparser;
- use selectors::*;
+ use selectors::parser::*;
use string_cache::Atom;
use properties::{PropertyDeclaration, DeclaredValue, longhands};
use std::borrow::ToOwned; |
SimonSapin
force-pushed
the
external-selectors
branch
from
abbc1ef
to
2a50755
Compare
bors-servo
pushed a commit
that referenced
this pull request
Feb 23, 2015
The new library is https://github.com/servo/rust-selectors. It’s not quite ready for other users (the API needs work), but this is a first step. servo/rust-selectors#2 should also be reviewed. Fixes #3669.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new library is https://github.com/servo/rust-selectors. It’s not quite ready for other users (the API needs work), but this is a first step.
servo/rust-selectors#2 should also be reviewed.
Fixes #3669.