Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spurious downloading lines in mach output from builders #5043

Closed
metajack opened this issue Feb 23, 2015 · 6 comments
Closed

spurious downloading lines in mach output from builders #5043

metajack opened this issue Feb 23, 2015 · 6 comments
Labels

Comments

@metajack
Copy link
Contributor

@metajack metajack commented Feb 23, 2015

See http://build.servo.org/builders/gonk/builds/29/steps/compile/logs/stdio for an example. Can we detect that we're not on a real terminal and then not do overwrites in that case?

@metajack metajack added the E-easy label Feb 23, 2015
@jdm jdm added the A-mach label Feb 24, 2015
@SimonSapin
Copy link
Member

@SimonSapin SimonSapin commented Feb 24, 2015

Do you mean the Downloading Rust snapshot: lines? We already have such a switch. They can be disabled with a TERM=dumb environment variable.

This switch could probably be smarter, maybe using sys.stdout.isatty()

aweinstock314 added a commit to aweinstock314/servo that referenced this issue Mar 2, 2015
bors-servo pushed a commit that referenced this issue Mar 3, 2015
...t based on sys.stdout.isatty() (Issue #5043).
@SimonSapin
Copy link
Member

@SimonSapin SimonSapin commented Mar 3, 2015

This was probably fixed in #5043, but I didn’t manage to find a newer builder log that downloads Rust. Do the builders cache Rust snapshots?

@jdm
Copy link
Member

@jdm jdm commented Mar 11, 2015

@larsbergstrom Do you know the answer?

@larsbergstrom
Copy link
Contributor

@larsbergstrom larsbergstrom commented Mar 11, 2015

Sadly, I believe we do not cache the Rust snapshots - they are in the build/.servo directory, and the build/ directory is blown away every time. We may want to do something similar to @Manishearth's changes to keep the .cargo directory global (servo/saltfs#19 ) to avoid this problem.

@jdm jdm removed the S-awaiting-answer label Mar 11, 2015
@jdm
Copy link
Member

@jdm jdm commented Mar 11, 2015

Downloading Rust snapshot...
Extracting Rust snapshot...
Snapshot Rust ready.

from http://build.servo.org/builders/linux1/builds/989/steps/compile/logs/stdio

@jdm jdm closed this Mar 11, 2015
@mbrubeck
Copy link
Contributor

@mbrubeck mbrubeck commented Mar 11, 2015

Filed #5200 for caching Rust snapshots outside of the working dir.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.