Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use quasiquote for attributes in plugin crate #5157

Closed
kmcallister opened this issue Mar 5, 2015 · 2 comments
Closed

Use quasiquote for attributes in plugin crate #5157

kmcallister opened this issue Mar 5, 2015 · 2 comments
Labels
E-easy I-cleanup

Comments

@kmcallister
Copy link
Contributor

@kmcallister kmcallister commented Mar 5, 2015

Now that rust-lang/rust#19674 is fixed.
@quix00
Copy link

@quix00 quix00 commented Mar 9, 2015

Hey @kmcallister
Would like to work on this bug but based on my observations we will need to update to a newer version of the rust nightly. Should an issue be opened for doing that work first?
@Ms2ger
Copy link
Contributor

@Ms2ger Ms2ger commented Mar 17, 2015

That's underway.
utkarshkukreti added a commit to utkarshkukreti/servo that referenced this issue Apr 3, 2015
@utkarshkukreti
Use quasiquotes for attributes in `plugins` crate.
ec4feeb 
Fixes servo#5157.
@utkarshkukreti utkarshkukreti mentioned this issue Apr 3, 2015
Closed
utkarshkukreti added a commit to utkarshkukreti/servo that referenced this issue Apr 3, 2015
@utkarshkukreti
Use quasiquotes for attributes in `plugins` crate.
f31d06e 
Fixes servo#5157.
Manishearth added a commit that referenced this issue Apr 4, 2015
@utkarshkukreti @Manishearth
Use quasiquotes for attributes in `plugins` crate.
5a35fa6 
Fixes #5157.
Ms2ger added a commit that referenced this issue Apr 4, 2015
@utkarshkukreti @Ms2ger
Use quasiquotes for attributes in `plugins` crate.
Loading status checks…
a934da8 
Fixes #5157.
@Ms2ger Ms2ger mentioned this issue Apr 4, 2015
Merged
bors-servo pushed a commit that referenced this issue Apr 7, 2015
bors-servo
Auto merge of #5523 - servo:use-quasiquote-for-attributes, r=jdm
Loading status checks…
d38fca6 
Fixes #5157.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
E-easy I-cleanup
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Use quasiquotes for attributes in `plugins` crate.
Use quasiquotes for attributes in `plugins` crate.
3 participants
@Ms2ger @kmcallister @quix00
You can’t perform that action at this time.