Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upMake same-origin navigations use the same script task #5239
Comments
|
Relevant code: Constellation::handle_load_url_msg. |
|
Oh, this isn't as easy as I suspected at first. This task basically involves adapting the AttachLayout message that the constellation sends to script - currently it's only used for a new iframe being added to a page. We want the constellation/script task to support the following cases:
|
|
I'd like to work on this. |
|
Please do :) |
|
@benschulz Ping |
|
I haven't gone past analysis on this one. So if you want to "steal" it, feel free. ;) |
|
Sure. I'll give a ping when I start work on it, in case someone else is looking for an issue to work on before I get to it. ;) |
(Do not merge) Use the same script thread if new location is same origin Fixes #5239. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12666) <!-- Reviewable:end -->
|
I suspect that the heavy-lifting is going to be done in script_thread::handle_new_layout when adapting |
(Do not merge) Use the same script thread if new location is same origin Fixes #5239. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12666) <!-- Reviewable:end -->
|
See #633. |
|
Clsoed by #14211. |
This yields better resource conservation, and is important for iframe navigation spec-compliance in particular.
Blocks #5236.