Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move back to enums in jsval.rs. #5273

Closed
Ms2ger opened this issue Mar 19, 2015 · 2 comments
Closed

Move back to enums in jsval.rs. #5273

Ms2ger opened this issue Mar 19, 2015 · 2 comments
Labels
A-content/bindings I-safety

Comments

@Ms2ger
Copy link
Contributor

@Ms2ger Ms2ger commented Mar 19, 2015

servo/rust-mozjs#137
rust-lang/rust#23304
@frewsxcv
Copy link
Member

@frewsxcv frewsxcv commented Aug 17, 2015

Update: both issues pasted above have now been addressed
frewsxcv added a commit to frewsxcv/rust-mozjs that referenced this issue Aug 17, 2015
@frewsxcv
Bring back the enums that were lost in the rustup
839310e 
We lost them in servo#137

Related to servo/servo#5273
@frewsxcv frewsxcv mentioned this issue Aug 17, 2015
Merged
bors-servo pushed a commit to servo/rust-mozjs that referenced this issue Aug 17, 2015
bors-servo
Auto merge of #188 - frewsxcv:bring-back-enums, r=Ms2ger
7cb98de 
Bring back the enums that were lost in the rustup

We lost them in #137

Related to servo/servo#5273

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/rust-mozjs/188)
<!-- Reviewable:end -->
@frewsxcv
Copy link
Member

@frewsxcv frewsxcv commented Aug 17, 2015

Fixed in servo/rust-mozjs#188
@frewsxcv frewsxcv closed this Aug 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-content/bindings I-safety
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@Ms2ger @frewsxcv
You can’t perform that action at this time.