Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Navigator.appVersion #5409

Closed
jdm opened this issue Mar 27, 2015 · 4 comments
Closed

Implement Navigator.appVersion #5409

jdm opened this issue Mar 27, 2015 · 4 comments
Labels
A-content/dom C-assigned E-easy

Comments

@jdm
Copy link
Member

@jdm jdm commented Mar 27, 2015

Spec: https://html.spec.whatwg.org/multipage/webappapis.html#dom-navigator-appversion
Code: components/script/dom/navigator.rs, components/script/dom/webidls/Navigator.webidl

Blocks #5406. It's used in the v8-raytrace.html test.
@jdm
Copy link
Member Author

@jdm jdm commented Mar 27, 2015

Alternatively we could try to get it removed from the test.
@deokjinkim
Copy link
Contributor

@deokjinkim deokjinkim commented Mar 27, 2015

I want to work on this stuff. I have a question about it. ^^
When I check "navigator.appVersion" on firefox, it returns "5.0 (X11)".
Servo also returns same string with firefox? or returns "4.0" according to spec? or servo has another application version?
@jdm
Copy link
Member Author

@jdm jdm commented Mar 27, 2015

I would go with 4.0.
@Ms2ger
Copy link
Contributor

@Ms2ger Ms2ger commented Mar 27, 2015

Follow the spec
deokjinkim added a commit to deokjinkim/servo that referenced this issue Mar 27, 2015
@deokjinkim
Implement Navigator.appVersion(servo#5409)
0a3242c
deokjinkim added a commit to deokjinkim/servo that referenced this issue Mar 30, 2015
@deokjinkim
Implement Navigator.appVersion(servo#5409)
6d5a51c
@deokjinkim deokjinkim mentioned this issue Mar 30, 2015
Closed
deokjinkim added a commit to deokjinkim/servo that referenced this issue Mar 30, 2015
@deokjinkim
Implement Navigator.appVersion(servo#5409)
a311e09
deokjinkim added a commit to deokjinkim/servo that referenced this issue Mar 31, 2015
@deokjinkim
Implement Navigator.appVersion(servo#5409)
c0e691b
@jdm jdm added the C-assigned label Apr 2, 2015
@jdm jdm closed this Apr 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-content/dom C-assigned E-easy
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@jdm @Ms2ger @deokjinkim
You can’t perform that action at this time.