Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make mouse_over_targets a RootedVec #5539

Closed
jdm opened this issue Apr 6, 2015 · 4 comments
Closed

Make mouse_over_targets a RootedVec #5539

jdm opened this issue Apr 6, 2015 · 4 comments
Labels
A-content/script C-assigned E-less easy

Comments

@jdm
Copy link
Member

@jdm jdm commented Apr 6, 2015

Vec<JS<T>> is unsafe, and we can do better now.

Code: components/script/dom/document.rs
@boghison
Copy link
Contributor

@boghison boghison commented Apr 6, 2015

Hmm, I am not quite familiar with the custom types that servo uses. How would one go about using iterators with RootedVec (since the current code uses iterators)?
@jdm
Copy link
Member Author

@jdm jdm commented Apr 6, 2015

RootedVec is just a wrapper for Vec, and it dereferences to the underlying vector. That means that all of the regular methods for vector objects should continue to work.
@boghison
Copy link
Contributor

@boghison boghison commented Apr 6, 2015

@jdm Can I give it a try?
@jdm
Copy link
Member Author

@jdm jdm commented Apr 6, 2015

Absolutely!
@jdm jdm added the C-assigned label Apr 6, 2015
@boghison boghison mentioned this issue Apr 7, 2015
Merged
bors-servo pushed a commit that referenced this issue Apr 19, 2015
bors-servo
Auto merge of #5567 - boghison:document_rootedvec, r=jdm
Loading status checks…
331708f 
Fixes #5539

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/5567)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-content/script C-assigned E-less easy
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Make mouse_over_targets a RootedVec
2 participants
@jdm @boghison
You can’t perform that action at this time.