Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'make clean' loops cleaning nss #556

Closed
kmcallister opened this issue Jul 2, 2013 · 2 comments
Closed

'make clean' loops cleaning nss #556

kmcallister opened this issue Jul 2, 2013 · 2 comments
Labels
A-infrastructure I-bustage I-wrong

Comments

@kmcallister
Copy link
Contributor

@kmcallister kmcallister commented Jul 2, 2013

I tried to build servo in-tree and ran into #378. When I try to clean up with make clean it goes into an infinite loop:

...
make[197]: Entering directory `/home/keegan/proj/servo/servo/src/support/nss/nss'
make -j1 -C /home/keegan/proj/servo/servo/src/support/nss/nss clean
make[198]: Entering directory `/home/keegan/proj/servo/servo/src/support/nss/nss'
make -j1 -C /home/keegan/proj/servo/servo/src/support/nss/nss clean
...

Servo is on master = fdb0d82
@metajack
Copy link
Contributor

@metajack metajack commented Jul 3, 2013

This is certainly not going to work in tree. The generated Makefile from Makefile.in calls make on the original Makefile.

I think a correct fix to this is to somehow detect an in-tree configure and/or make and fail with an appropriate error message.
@jdm
Copy link
Member

@jdm jdm commented Apr 18, 2014

NSS is gone.
@jdm jdm closed this Apr 18, 2014
ChrisParis pushed a commit to ChrisParis/servo that referenced this issue Sep 7, 2014
@jgraham
Merge pull request servo#556 from w3c/jgraham/path_config
80a184d 
Allow doc_root and ws_doc_root to be passed in as config options.
glennw pushed a commit to glennw/servo that referenced this issue Jan 16, 2017
@bors-servo
Auto merge of servo#556 - kvark:clip_stack, r=glennw
9b72d1b 
Off-screen clip mask generation

This is the second major step towards servo#498
Edit: now actually includes the third step as well (removal of `*_clip` shaders).

The PR makes all the clip masks to be generated via the cached rendering tasks (of the new kind). These task work on the area of intersection between all the clip items. The resulting draw calls are being batched via the new `ClipBatcher`.

It supports everything that we currently support, plus the actual handling of arbitrary number of clips.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/556)
<!-- Reviewable:end -->
@jdm jdm mentioned this issue Nov 5, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-infrastructure I-bustage I-wrong
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@jdm @metajack @kmcallister
You can’t perform that action at this time.