Implement History's back/forward APIs

[jdm]

Spec: https://html.spec.whatwg.org/multipage/browsers.html#the-history-interface, https://html.spec.whatwg.org/multipage/browsers.html#dom-history-back,
Code: https://github.com/servo/servo/wiki/Adding-a-new-WebIDL-binding

This will just end up mimicing the behaviour of the GoForward/GoBack APIs of HTMLIFrameElement (see components/script/dom/element/htmliframelement.rs)

[jdm]

cc #5669

[aneeshusa]

I'd like to try this one out for size.

[jdm]

It's yours!

[ghost]

Hi, could someone help me out where I could find the code relevant to fix this bug.

[jdm]

@jinankjain are the links in the original comment unclear? This task requires creating a new webidl interface and a new Rust implementation of the interface, but there are also existing methods in htmliframeelement.rs that can be used as models.

[snf]

Browser context needs some work and there are tons of TODO(handle browsing context) out there in the dom files so I think we should start there.

And wouldn't this struct keep alive all the Document, Window, etc context from the browsing history creating a little memory leak?:

// This isn't a DOM struct, just a convenience struct
// without a reflector, so we don't mark this as #[dom_struct]
#[must_root]
#[privatize]
#[jstraceable]
pub struct SessionHistoryEntry {
    document: JS<Document>,
    children: Vec<BrowserContext>
}

Also, should we add something else in the script_task/constellation?

[jdm]

It technically won't be a leak, since it will be removed when the script task shuts down. We should also add logic to prune the actual cached document at some point, but that will require extra logic to reload it if we end up trying to retrieve it from history later.

[snf]

@aneeshusa or @jinankjain still working on this one?

[vectorijk]

@snf are you also working on this one?
@jdm I would like to try this one.

[snf]

@vectorijk no, devs don't allow me to work in e-easy bugs anymore :'( . So all yours if no one is working on it.

[jdm]

Yes, go for it :)

[boghison]

@vectorijk Excuse me, are you still working on this?

[vectorijk]

@boghison Yes,I am still working on it. Cause I am a newbie, I am doing some research
on how to implement this api and also digged into how WebKit and gecko
wrote on this api.
On Jul 16, 2015 10:04 AM, "Bogdan Cuza" notifications@github.com wrote:

@vectorijk https://github.com/vectorijk Excuse me, are you still
working on this?

—
Reply to this email directly or view it on GitHub
#5670 (comment).

[jdm]

Made any progress @vectorijk? Any questions I can answer?

[tomjakubowski]

I'd like to take this on!

[vectorijk]

@tomjakubowski I am off~.

[jdm]

Sounds like it's all yours, @tomjakubowski.

[jdm]

#7520 was proposed to implement this. It got stuck on the requirement to write tests; I'm not comfortable leaving this marked as E-easy until we come up with suggestions for how to write tests for it.

[cbrewster]

I am picking this one back up. I am implementing pushState so the history tests can be enabled