Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upMultiple interface definitions in the same WebIDL file yield duplicate autogenerated definitions #571
Labels
Comments
|
We could probably put them into their own modules. |
|
Do we wish to fix that at all? Should we care? I think it's nice to have only one interface per WebIDL file. |
|
If we don't plan to fix it, we should report the error earlier. |
bors-servo
added a commit
that referenced
this issue
Aug 24, 2016
Support pair and value iterable WebIDL bindings The actual iterator implementation and JSAPI calls related to setting up the interface are ported directly from Gecko's Codegen.py, IterableIterator.h, and IterableIterator.webidl. The changes to support multiple interfaces in one file are required because the internal iterator interface the parser generates gets associated with the original interface's WebIDL file. It seemed like a good time to address #571 in that case. --- - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #12628 and fix #571. - [X] There are tests for these changes <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12819) <!-- Reviewable:end -->
bors-servo
added a commit
that referenced
this issue
Aug 24, 2016
Support pair and value iterable WebIDL bindings The actual iterator implementation and JSAPI calls related to setting up the interface are ported directly from Gecko's Codegen.py, IterableIterator.h, and IterableIterator.webidl. The changes to support multiple interfaces in one file are required because the internal iterator interface the parser generates gets associated with the original interface's WebIDL file. It seemed like a good time to address #571 in that case. --- - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #12628 and fix #571. - [X] There are tests for these changes <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12819) <!-- Reviewable:end -->
glennw
pushed a commit
to glennw/servo
that referenced
this issue
Jan 16, 2017
Add a generate_frame API function to recomposite the last content For Firefox we need to do this sometimes, for a variety of reasons. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/571) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Functions like
GetProtoObjectare duplicated for each autogenerated binding, so rustc complains.