Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NodeTypeId should include CharacterData variant #5869

Closed
jdm opened this issue Apr 27, 2015 · 3 comments
Closed

NodeTypeId should include CharacterData variant #5869

jdm opened this issue Apr 27, 2015 · 3 comments
Labels
A-content/dom C-assigned E-easy I-refactor

Comments

@jdm
Copy link
Member

@jdm jdm commented Apr 27, 2015

NodeTypeId is supposed to reflect the WebIDL inheritance hierarchy. All of Text/ProcessingInstruction/Comment inherit from CharacterData, which inherits from Node. There should be a CharacterDataTypeId value that differentiates between those, instead.
@Jinwoo-Song
Copy link
Contributor

@Jinwoo-Song Jinwoo-Song commented Apr 28, 2015

I'd like to try this one!
@Jinwoo-Song
Copy link
Contributor

@Jinwoo-Song Jinwoo-Song commented Apr 28, 2015

Uploaded a patch. Jinwoo-Song@0acf9f4
@jdm jdm added the C-assigned label Apr 28, 2015
@nox
Copy link
Member

@nox nox commented Apr 30, 2015

Fixed by #5879.
@Ms2ger Ms2ger closed this Apr 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-content/dom C-assigned E-easy I-refactor
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
@jdm @Ms2ger @nox @Jinwoo-Song
You can’t perform that action at this time.