Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TextEncoder::Constructor should not trim whitespace / lowercase its label #5900

Closed
Ms2ger opened this issue Apr 30, 2015 · 2 comments
Closed

TextEncoder::Constructor should not trim whitespace / lowercase its label #5900

Ms2ger opened this issue Apr 30, 2015 · 2 comments
Labels
A-content/dom C-assigned E-easy I-wrong

Comments

@Ms2ger
Copy link
Contributor

@Ms2ger Ms2ger commented Apr 30, 2015

encoding_from_whatwg_label already does that correctly.

Blocks #5601.
psdh added a commit to psdh/servo that referenced this issue Apr 30, 2015
@psdh
TextEncoder::Constructor should not trim whitespaces or lowercase lab…
3c7cdc8 
…els servo#5900

Fixes servo#5900
@psdh psdh mentioned this issue Apr 30, 2015
Merged
psdh added a commit to psdh/servo that referenced this issue Apr 30, 2015
@psdh
TextEncoder::Constructor should not trim whitespaces or lowercase lab…
1d0976c 
…els servo#5900

Fixes servo#5900
@jdm jdm added the C-assigned label Apr 30, 2015
@SimonSapin
Copy link
Member

@SimonSapin SimonSapin commented Apr 30, 2015

I’m pretty sure I did that in passing at some point of the current rustup. It must have been lost if a rebase.
@Ms2ger
Copy link
Contributor Author

@Ms2ger Ms2ger commented May 1, 2015

Yeah, I removed it; I don't believe it belongs there
bors-servo pushed a commit that referenced this issue May 1, 2015
bors-servo
Auto merge of #5903 - psdh:textencoder5900, r=Ms2ger
Loading status checks…
ba8eaac 
... #5900

Fixes #5900

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/5903)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-content/dom C-assigned E-easy I-wrong
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

TextEncoder::Constructor should not trim whitespaces or lowercase labels...
3 participants
@jdm @Ms2ger @SimonSapin
You can’t perform that action at this time.