Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a profile_traits crate to reduce compile times. #5912

Merged
merged 1 commit into from May 1, 2015

Conversation

nnethercote
Copy link
Contributor

A rebuild after touching components/profile/mem.rs now takes 48 seconds (and
only rebuilds profile and servo) which is much lower than it used to be.
In comparison, a rebuild after touching components/profile_traits/mem.rs takes
294 seconds and rebuilds many more crates.

This change also removes some unnecessary crate dependencies in net and
net_traits.

Review on Reviewable

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label May 1, 2015
@hoppipolla-critic-bot
Copy link

Critic review: https://critic.hoppipolla.co.uk/r/4870

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

A rebuild after touching components/profile/mem.rs now takes 48 seconds (and
only rebuilds `profile` and `servo`) which is much lower than it used to be.
In comparison, a rebuild after touching components/profile_traits/mem.rs takes
294 seconds and rebuilds many more crates.

This change also removes some unnecessary crate dependencies in `net` and
`net_traits`.
@Manishearth
Copy link
Member

Reviewed files:

  • components/compositing/Cargo.toml @ r1
  • components/compositing/compositor.rs @ r1
  • components/compositing/compositor_task.rs @ r1
  • components/compositing/constellation.rs @ r1
  • components/compositing/headless.rs @ r1
  • components/compositing/lib.rs @ r1
  • components/compositing/pipeline.rs @ r1
  • components/gfx/Cargo.toml @ r1
  • components/gfx/lib.rs @ r1
  • components/gfx/paint_task.rs @ r1
  • components/layout/Cargo.toml @ r1
  • components/layout/layout_task.rs @ r1
  • components/layout/lib.rs @ r1
  • components/layout/parallel.rs @ r1
  • components/layout_traits/Cargo.toml @ r1
  • components/layout_traits/lib.rs @ r1
  • components/net/Cargo.toml @ r1
  • components/net/lib.rs @ r1
  • components/net_traits/Cargo.toml @ r1
  • components/net_traits/lib.rs @ r1
  • components/profile/Cargo.toml @ r1
  • components/profile/lib.rs @ r1
  • components/profile/mem.rs @ r1
  • components/profile/time.rs @ r1
  • components/profile_traits/Cargo.toml @ r1
  • components/profile_traits/lib.rs @ r1
  • components/profile_traits/mem.rs @ r1
  • components/profile_traits/time.rs @ r1
  • components/script/Cargo.toml @ r1
  • components/script/layout_interface.rs @ r1
  • components/script/lib.rs @ r1
  • components/servo/Cargo.lock @ r1
  • components/servo/Cargo.toml @ r1
  • components/servo/lib.rs @ r1
  • ports/cef/Cargo.lock @ r1
  • tests/unit/net/Cargo.toml @ r1
  • tests/unit/net/lib.rs @ r1

Comments from the review on Reviewable.io

@Manishearth
Copy link
Member

Reviewed files:

  • components/profile_traits/time.rs @ r2

Comments from the review on Reviewable.io

@Manishearth
Copy link
Member

@bors-servo: r+

@bors-servo
Copy link
Contributor

📌 Commit 092507d has been approved by Manishearth

@bors-servo
Copy link
Contributor

⌛ Testing commit 092507d with merge 77f653d...

bors-servo pushed a commit that referenced this pull request May 1, 2015
A rebuild after touching components/profile/mem.rs now takes 48 seconds (and
only rebuilds `profile` and `servo`) which is much lower than it used to be.
In comparison, a rebuild after touching components/profile_traits/mem.rs takes
294 seconds and rebuilds many more crates.

This change also removes some unnecessary crate dependencies in `net` and
`net_traits`.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/5912)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - android, gonk, linux1, linux2, mac1, mac2

@bors-servo bors-servo merged commit 092507d into servo:master May 1, 2015
@nnethercote nnethercote deleted the profile_traits branch May 28, 2015 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-awaiting-review There is new code that needs to be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants