Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print a warning about performance after a debug build completes #5933

Closed
mbrubeck opened this issue May 4, 2015 · 1 comment

Comments

Projects
None yet
2 participants
@mbrubeck
Copy link
Contributor

commented May 4, 2015

When running mach build without the --release flag, print a message to the user about performance. Something like:

Warning: This is an un-optimized debug build. For performance testing, use ./mach build --release to enable compiler optimizations.

The goal is to prevent users from unknowingly doing benchmarking or perf comparisons on debug builds. The message can be printed at the end of the build function here:

https://github.com/servo/servo/blob/master/python/servo/build_commands.py

@machineloop

This comment has been minimized.

Copy link

commented May 5, 2015

First contribution, thanks for the low hanging fruit. Hopefully I can submit a PR involving Rust next time... :)

jinankjain added a commit to jinankjain/servo that referenced this issue May 6, 2015

jinankjain added a commit to jinankjain/servo that referenced this issue May 6, 2015

jinankjain added a commit to jinankjain/servo that referenced this issue May 7, 2015

jinankjain added a commit to jinankjain/servo that referenced this issue May 8, 2015

jinankjain added a commit to jinankjain/servo that referenced this issue May 9, 2015

jinankjain added a commit to jinankjain/servo that referenced this issue May 9, 2015

jinankjain added a commit to jinankjain/servo that referenced this issue May 9, 2015

@mbrubeck mbrubeck closed this in c98d55f May 14, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.