Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up util::geometry API #5943

Closed
SimonSapin opened this issue May 5, 2015 · 0 comments
Closed

Clean up util::geometry API #5943

SimonSapin opened this issue May 5, 2015 · 0 comments
Assignees

Comments

@SimonSapin
Copy link
Member

@SimonSapin SimonSapin commented May 5, 2015

  • The naming is inconsistent: #5935 (comment)
  • frac and subpx seem to mean the same thing
  • Some items are free functions and some are Au methods, for no apparent reason. Sometimes both exist and are redundant.
@SimonSapin SimonSapin self-assigned this May 5, 2015
This was referenced May 5, 2015
bors-servo pushed a commit that referenced this issue May 5, 2015
Fix #5943.

r? @mbrubeck

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/5951)
<!-- Reviewable:end -->
bors-servo pushed a commit that referenced this issue May 5, 2015
Fix #5943.

r? @mbrubeck

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/5951)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

1 participant
You can’t perform that action at this time.