Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass the WebSockets test suite. #6060

Open
Ms2ger opened this issue May 15, 2015 · 4 comments
Open

Pass the WebSockets test suite. #6060

Ms2ger opened this issue May 15, 2015 · 4 comments
Labels

Comments

@Ms2ger
Copy link
Contributor

@Ms2ger Ms2ger commented May 15, 2015

Tests are under tests/wpt/web-platform-tests/websockets, and expected failures are under tests/wpt/metadata/websockets/. See tests/wpt/README.md for more information on web platform tests.

@Chandler
Copy link

@Chandler Chandler commented Jan 15, 2016

@jdm What's the best way to get started finding more websockets tests to fix. Should I just look for anything with "expected: FAIL" under tests/wpt/web-platform-tests/websockets ?

All the existing websockets tickets are already being worked on https://github.com/servo/servo/issues?utf8=%E2%9C%93&q=is%3Aissue+is%3Aopen+websockets

@KiChjang
Copy link
Member

@KiChjang KiChjang commented Jan 15, 2016

@Chandler Yes, we don't necessarily have issues for every failing test, so it's perfectly ok for you to submit a PR and fix them!

@jsanders
Copy link
Contributor

@jsanders jsanders commented Jan 20, 2016

@Chandler: FYI, a dump of all the current failures (not including what you fixed in #9367): https://gist.github.com/jsanders/4a348d15aa27067d2b02

@nox
Copy link
Member

@nox nox commented Sep 30, 2017

There is still a ton of failing tests, notably since we disabled support of wss.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants
You can’t perform that action at this time.