Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRemove unnecessary calls to node_removed and change semantics of node_inserted #6229
Labels
Comments
|
I'd like to take! |
|
Go for it! |
|
@gaye are you working on this one? I'd like to take a stab at it if not. |
|
@nick-thompson Be my guest! I got caught up in some other work. |
|
I think I'm already covering this in #6660, you might want to work on something else. Sorry I didn't notice this ticket. |
|
Yep, looks like your commit covers all of the code I was about to change. Thanks for the heads up, I'll look for something else. I'll leave this for a more senior contributor to verify and close out ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
PR #5972 has changed the semantics of
node_removedso that it now corresponds to the "removal steps" in the spec and doesn't perform any steps related to "mutation observers". Hence,as explained here, the calls to node_removed from Node::ReplaceChild and Node::replace_all should be removed.
Additionally to keep things symmetric,
node_insertedcan also be called unconditionally frominsertand the calls from replace_all and ReplaceChild can be removed as well, so that node_inserted will correspond to the "insertion steps" in the spec.