Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSS 'transformation: skew()' should take <angle> type as parameters #6237

Closed
Jinwoo-Song opened this issue Jun 1, 2015 · 0 comments
Closed

CSS 'transformation: skew()' should take <angle> type as parameters #6237

Jinwoo-Song opened this issue Jun 1, 2015 · 0 comments
Assignees
@nox
Labels
A-content/css C-assigned

Comments

@Jinwoo-Song
Copy link
Contributor

@Jinwoo-Song Jinwoo-Song commented Jun 1, 2015

Current implementation is taking type as parameter so skew() does not work properly now.
Jinwoo-Song added a commit to Jinwoo-Song/servo that referenced this issue Jun 1, 2015
@Jinwoo-Song
CSS 'transformation: skew()' should take <angle> type as parameters
c185321 
Current implementation is taking <number> type as parameter so skew()
does not work properly. Let the skew() to get <angle> as specification
described.

Fixes servo#6237.
@Jinwoo-Song Jinwoo-Song mentioned this issue Jun 1, 2015
Closed
Jinwoo-Song added a commit to Jinwoo-Song/servo that referenced this issue Jun 2, 2015
@Jinwoo-Song
CSS 'transformation: skew()' should take <angle> type as parameters
2c83111 
Current implementation is taking <number> type as parameter so skew()
does not work properly. Let the skew() to get <angle> as specification
described.

Fixes servo#6237.
bors-servo pushed a commit that referenced this issue Jun 2, 2015
bors-servo
Auto merge of #6238 - Jinwoo-Song:skew, r=nox
2356273 
Current implementation is taking <number> type as parameter so skew()
does not work properly. Let the skew() to get <angle> as specification
described.

Fixes #6237.

r? @pcwalton 
cc @yichoi

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6238)
<!-- Reviewable:end -->
@Jinwoo-Song Jinwoo-Song mentioned this issue Jun 12, 2015
Closed
@nox nox mentioned this issue Jun 12, 2015
Merged
nox added a commit to nox/servo that referenced this issue Sep 11, 2015
@Jinwoo-Song @nox
CSS 'transformation: skew()' should take <angle> type as parameters
8b7bbb8 
Current implementation is taking <number> type as parameter so skew()
does not work properly. Let the skew() to get <angle> as specification
described.

Fixes servo#6237.
nox added a commit to nox/servo that referenced this issue Sep 11, 2015
@Jinwoo-Song @nox
CSS 'transformation: skew()' should take <angle> type as parameters
d229312 
Current implementation is taking <number> type as parameter so skew()
does not work properly. Let the skew() to get <angle> as specification
described.

Fixes servo#6237.
nox added a commit to nox/servo that referenced this issue Sep 11, 2015
@Jinwoo-Song @nox
CSS 'transformation: skew()' should take <angle> type as parameters
f9b7f68 
Current implementation is taking <number> type as parameter so skew()
does not work properly. Let the skew() to get <angle> as specification
described.

Fixes servo#6237.
@nox nox added the A-content/css label Sep 11, 2015
@nox nox self-assigned this Sep 11, 2015
@nox nox added the C-assigned label Sep 11, 2015
@nox nox mentioned this issue Sep 11, 2015
Merged
nox added a commit to nox/servo that referenced this issue Sep 11, 2015
@Jinwoo-Song @nox
CSS 'transformation: skew()' should take <angle> type as parameters
d524601 
Current implementation is taking <number> type as parameter so skew()
does not work properly. Let the skew() to get <angle> as specification
described.

Fixes servo#6237.
bors-servo pushed a commit that referenced this issue Sep 15, 2015
bors-servo
Auto merge of #7605 - nox:skew, r=mbrubeck
9dc2c81 
Implement "transform: skew()"

Thanks to @Jinwoo-Song for the original commit, which I just rebased and cleaned up. Fixes #6237.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7605)
<!-- Reviewable:end -->
bors-servo pushed a commit that referenced this issue Sep 16, 2015
bors-servo
Auto merge of #7605 - nox:skew, r=mbrubeck
Loading status checks…
6a12f00 
Implement "transform: skew()"

Thanks to @Jinwoo-Song for the original commit, which I just rebased and cleaned up. Fixes #6237.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7605)
<!-- Reviewable:end -->
jdramani added a commit to jdramani/servo that referenced this issue Sep 18, 2015
@Jinwoo-Song @jdramani
CSS 'transformation: skew()' should take <angle> type as parameters
a4a88b3 
Current implementation is taking <number> type as parameter so skew()
does not work properly. Let the skew() to get <angle> as specification
described.

Fixes servo#6237.
josiahdaniels added a commit to josiahdaniels/servo that referenced this issue Sep 28, 2015
@Jinwoo-Song @josiahdaniels
CSS 'transformation: skew()' should take <angle> type as parameters
eb319a7 
Current implementation is taking <number> type as parameter so skew()
does not work properly. Let the skew() to get <angle> as specification
described.

Fixes servo#6237.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nox nox

Labels
A-content/css C-assigned
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

CSS 'transformation: skew()' should take <angle> type as parameters
Apply skew transformation for alpha and beta angles.
2 participants
@nox @Jinwoo-Song
You can’t perform that action at this time.