Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure out how to support returning base DOM interfaces from derived ones #626

Closed
jdm opened this issue Jul 26, 2013 · 1 comment
Closed

Figure out how to support returning base DOM interfaces from derived ones #626

jdm opened this issue Jul 26, 2013 · 1 comment

Comments

@jdm
Copy link
Member

@jdm jdm commented Jul 26, 2013

Stuff like createEvent in Document returns an Event, which currently translates to @mut Event, when the concrete type might be @mut MouseEvent. This should be easier when we switch to JSManaged<Event> since we can just say it's whatever type we want, cause it's the same pointer. Until then maybe we just punt.

@jdm
Copy link
Member Author

@jdm jdm commented Nov 5, 2013

AbstractFoo.

@jdm jdm closed this Nov 5, 2013
ChrisParis pushed a commit to ChrisParis/servo that referenced this issue Sep 7, 2014
…-validation

Fix a bug of the form controls validation test
glennw pushed a commit to glennw/servo that referenced this issue Jan 16, 2017
Fix type mismatch in shared shader code

This fixes a `Type mismatch, cannot convert from 'ivec2' to 'vec2'` error produced by Servo on Android.

Related: servo#13154

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/626)
<!-- Reviewable:end -->
glennw pushed a commit to glennw/servo that referenced this issue Jan 16, 2017
Fix a type mismatch in `cs_blur.vs.glsl`

Similarly to servo#626.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/633)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.