Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up core text / core graphics bindings #63

Closed
brson opened this issue Sep 7, 2012 · 4 comments
Closed

Clean up core text / core graphics bindings #63

brson opened this issue Sep 7, 2012 · 4 comments

Comments

@brson
Copy link
Contributor

@brson brson commented Sep 7, 2012

Some of the CG bindings are in rust-cocoa. They should be moved to rust-core-graphics, and rust-cocoa removed from servo. quartz_native_font contains some core text bindings that should be moved to rust-core-text.

They all need high-level bindings that manage destruction properly.

@pcwalton
Copy link
Contributor

@pcwalton pcwalton commented Sep 7, 2012

CTFonts look like Core Foundation objects (they use CFRelease). The rust-core-foundation API objects help manage the lifecycle of these properly.

@burg
Copy link

@burg burg commented Sep 11, 2012

Where possible, we should mirror bindings after the divisions in native APIs. So, one for CG, CT, CF---with higher-level help in rust-core-foundation.

@burg
Copy link

@burg burg commented Oct 19, 2012

I created rust-core-graphics to hold the CG bindings already used, and will next make rust-core-text. Then, we can move the remainder of rust-cocoa to rust-core-foundation and remove rust-cocoa. Then, rust-cg and rust-ct can be given high-level bindings incrementally.

@burg
Copy link

@burg burg commented Oct 25, 2012

Followup bug #152

@burg burg closed this Oct 25, 2012
ChrisParis pushed a commit to ChrisParis/servo that referenced this issue Sep 7, 2014
Combine the functions so that servo#63, servo#66 ~ servo#69 can remove the file.

Still keep IndexedDB/support.js use vendor prefix.
glennw added a commit to glennw/servo that referenced this issue Jan 16, 2017
Small restructure of image id hash maps.
glennw pushed a commit to glennw/servo that referenced this issue Jan 16, 2017
Remove use of Matrix4 that is deprecated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.