New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use <base> in resolving url attributes (like "href"). #6303
Conversation
Critic review: https://critic.hoppipolla.co.uk/r/5205 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
Let's not run |
I've discussed with @eddyb about what he should do on IRC. Assigning ticket to myself because I'm curious about reviewing it. |
@nox: Can you add the changes that needed to be made here? |
Will do today or tonight. |
I think I agree with @bzbarsky that we should add a |
You need that Given also that resolving URIs happens a good bit during pageload, you want to store the "fallback base URL" directly in the document, and probably store the "document base URL" as well (updating it when |
Sorry about the ambiguous wording; I was really asking if the proposed changes mentioned in "I've discussed with @eddyb about what he should do on IRC" could be listed here so it was clear what work still remains. I wasn't actually trying to crack the whip on anybody. |
Needs to look for |
We should implement |
@nox ping? |
@metajack Will take it over I guess. |
I'm working on a better approach. |
Use <base> in resolving url attributes (like "href"). Second take of #6303, now that the `base_url` infrastructure is in place. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10247) <!-- Reviewable:end -->
Use <base> in resolving url attributes (like "href"). Second take of #6303, now that the `base_url` infrastructure is in place. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10247) <!-- Reviewable:end -->
Use <base> in resolving url attributes (like "href"). Second take of #6303, now that the `base_url` infrastructure is in place. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10247) <!-- Reviewable:end -->
This allows polymer demos to load. For example, paper-buttons:
Running the demo also requires the following userscript: