Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relative time doesn't work properly #6407

Open
mdinger opened this issue Jun 17, 2015 · 6 comments
Open

Relative time doesn't work properly #6407

mdinger opened this issue Jun 17, 2015 · 6 comments
Labels
A-content/dom

Comments

@mdinger
Copy link

@mdinger mdinger commented Jun 17, 2015

testcase1
smaller testcase2 based on @Scorpil's comment.

Relative time doesn't work properly. This is a shrunk down testcase from a page like servo/issues. The testcase isn't reproducible if I have the script locally. Not sure why.

<html>
<head> </head>
<body>
    <time datetime="2015-06-11T18:08:12Z" is="relative-time"></time> by
    <script crossorigin="anonymous" src="https://assets-cdn.github.com/assets/frameworks-808fcfcd63c9ecba3e84453f540cb1cbafde48c6b30c1d51ebd4e67e88ff66bd.js"></script>
</body>
</html>

On servo:
servo

On firefox:
firefox

Github in firefox:
firefox_full

It's a hassle getting the html hosted and it doesn't seem possible to just link it here easily. Bugzilla does it much nicer in this respect.
@jdm
Copy link
Member

@jdm jdm commented Jun 21, 2015

Looks like the relevant code might be the Facebox jQuery component.
@Scorpil
Copy link
Contributor

@Scorpil Scorpil commented Jun 24, 2015

Example from time-elements.js is a nice way to test it locally: https://github.com/github/time-elements/blob/master/examples/polymer.html

The problem is actually in webcomponents.js:

ERROR:js::rust: Error at https://cdnjs.cloudflare.com/ajax/libs/webcomponentsjs/0.5.4/webcomponents.js:111: Error: Assertion failed
ERROR:js::rust: Error at file:///tmp/time-elements.js:504: TypeError: document.registerElement is not a function
@mdinger
Copy link
Author

@mdinger mdinger commented Jun 25, 2015

@Scorpil Thanks for that. I updated the OP.
@mdinger
Copy link
Author

@mdinger mdinger commented Jan 30, 2016

Still a problem with 3165781
@jdm jdm added the A-content/dom label Jan 30, 2016
@jdm
Copy link
Member

@jdm jdm commented Jan 30, 2016

That error message should be solved by #9372, but it's not clear to me whether webcomponents.js is supposed to have a polyfill working without that support.
@jdm
Copy link
Member

@jdm jdm commented Mar 3, 2017

The error on the polymer example page now reads:

ERROR:script::dom::bindings::error: Error at https://cdnjs.cloudflare.com/ajax/libs/webcomponentsjs/0.7.23/webcomponents.min.js:12:30616 c is undefined
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-content/dom
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@jdm @Scorpil @mdinger
You can’t perform that action at this time.