Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement document.hasFocus #6475

Closed
mbrubeck opened this issue Jun 26, 2015 · 3 comments
Closed

Implement document.hasFocus #6475

mbrubeck opened this issue Jun 26, 2015 · 3 comments

Comments

@mskrzypkows
Copy link

@mskrzypkows mskrzypkows commented Jun 29, 2015

I can try this task.

@mbrubeck mbrubeck added the C-assigned label Jun 29, 2015
@mskrzypkows
Copy link

@mskrzypkows mskrzypkows commented Jul 20, 2015

I'm trying to implement point 4. form: https://html.spec.whatwg.org/multipage/interaction.html#dom-document-hasfocus. How can I check if document has a dialog group, then how to check if document has a non-empty control group? I haven't found any method returning it, is it available in servo?

@mbrubeck
Copy link
Contributor Author

@mbrubeck mbrubeck commented Jul 20, 2015

How can I check if document has a dialog group, then how to check if document has a non-empty control group?

I believe Servo does not yet support these features. You can just skip this step for now, and put a "TODO" comment in the code.

mskrzypkows pushed a commit to mskrzypkows/servo that referenced this issue Jul 25, 2015
mskrzypkows pushed a commit to mskrzypkows/servo that referenced this issue Jul 25, 2015
mskrzypkows pushed a commit to mskrzypkows/servo that referenced this issue Aug 3, 2015
bors-servo pushed a commit that referenced this issue Aug 3, 2015
Implementing document.hasFocus method, needs tests. #6475

I'm not sure if I have to implement some test for a new document method. As I remember there were tests for document methods, is it changed now? Where should I add tests?

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6757)
<!-- Reviewable:end -->
mskrzypkows pushed a commit to mskrzypkows/servo that referenced this issue Aug 10, 2015
bors-servo pushed a commit that referenced this issue Aug 11, 2015
Implementing document.hasFocus method, needs tests. #6475

I'm not sure if I have to implement some test for a new document method. As I remember there were tests for document methods, is it changed now? Where should I add tests?

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6757)
<!-- Reviewable:end -->
fabricedesre added a commit to fabricedesre/servo that referenced this issue Aug 14, 2015
@jdm jdm closed this Sep 18, 2015
josiahdaniels added a commit to josiahdaniels/servo that referenced this issue Sep 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.