Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some CSS text properties are not incremental layout safe #6501

Closed
mbrubeck opened this issue Jun 27, 2015 · 0 comments
Closed

Some CSS text properties are not incremental layout safe #6501

mbrubeck opened this issue Jun 27, 2015 · 0 comments
Assignees
@mbrubeck
Labels
A-layout/text I-wrong

Comments

@mbrubeck
Copy link
Contributor

@mbrubeck mbrubeck commented Jun 27, 2015

The following properties are used during text run construction and glyph shaping, which happens during flow construction. When incremental layout is enabled, changes to these styles have no effect:

  • text-rendering
  • word-spacing
  • letter-spacing
  • text-transform
  • font (and related longhands)

For example, hovering over the text in this example does not apply the expected letter-spacing:

<html>
  <head>
    <style>
      p:hover { letter-spacing: 1em; }
    </style>
  </head>
  <body>
    <p>Hello, world!</p>
  </body>
</html>
@mbrubeck mbrubeck self-assigned this Jun 27, 2015
@mbrubeck mbrubeck mentioned this issue Jun 27, 2015
Closed
mbrubeck added a commit to mbrubeck/servo that referenced this issue Sep 17, 2015
@mbrubeck
Reconstruct flows when text/font styles change
60a3e64 
Fixes servo#6501.
@mbrubeck mbrubeck mentioned this issue Sep 17, 2015
Merged
mbrubeck added a commit to mbrubeck/servo that referenced this issue Sep 17, 2015
@mbrubeck
Reconstruct flows when text/font styles change
58c994c 
Fixes servo#6501.
bors-servo pushed a commit that referenced this issue Sep 17, 2015
bors-servo
Auto merge of #7656 - mbrubeck:incremental-text-6501, r=pcwalton
cd8c11b 
Reconstruct flows when text/font styles change

These styles are used during text shaping.  When they change, we need to re-run shaping and construct new flows.

Fixes #6501. r? @pcwalton

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7656)
<!-- Reviewable:end -->
mbrubeck added a commit to mbrubeck/servo that referenced this issue Sep 17, 2015
@mbrubeck
Reconstruct flows when text/font/list styles change
0c77705 
Fixes servo#6501.
bors-servo pushed a commit that referenced this issue Sep 18, 2015
bors-servo
Auto merge of #7656 - mbrubeck:incremental-text-6501, r=pcwalton
Loading status checks…
acde10f 
Reconstruct flows when text/font styles change

These styles are used during text shaping.  When they change, we need to re-run shaping and construct new flows.

Fixes #6501. r? @pcwalton

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7656)
<!-- Reviewable:end -->
jdramani added a commit to jdramani/servo that referenced this issue Sep 18, 2015
@mbrubeck @jdramani
Reconstruct flows when text/font/list styles change
7f8fc7b 
Fixes servo#6501.
josiahdaniels added a commit to josiahdaniels/servo that referenced this issue Sep 28, 2015
@mbrubeck @josiahdaniels
Reconstruct flows when text/font/list styles change
5e124db 
Fixes servo#6501.
@mbrubeck mbrubeck mentioned this issue May 20, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mbrubeck mbrubeck

Labels
A-layout/text I-wrong
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
@mbrubeck
You can’t perform that action at this time.