Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove *Cast::from_actual. #6549

Merged
merged 1 commit into from Jul 4, 2015
Merged

Remove *Cast::from_actual. #6549

merged 1 commit into from Jul 4, 2015

Conversation

Ms2ger
Copy link
Contributor

@Ms2ger Ms2ger commented Jul 4, 2015

Since JSRef was removed, from_actual duplicates from_ref.

Review on Reviewable

Since JSRef was removed, from_actual duplicates from_ref.
@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Jul 4, 2015
@nox
Copy link
Contributor

nox commented Jul 4, 2015

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit 2f88b84 has been approved by nox

@bors-servo
Copy link
Contributor

⌛ Testing commit 2f88b84 with merge 0298c92...

@nox nox self-assigned this Jul 4, 2015
bors-servo pushed a commit that referenced this pull request Jul 4, 2015
Remove *Cast::from_actual.

Since JSRef was removed, from_actual duplicates from_ref.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6549)
<!-- Reviewable:end -->
@nox nox added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Jul 4, 2015
@bors-servo
Copy link
Contributor

☀️ Test successful - android, gonk, linux1, linux2, linux3, mac1, mac2, mac3

@bors-servo bors-servo merged commit 2f88b84 into servo:master Jul 4, 2015
@Ms2ger Ms2ger deleted the from_actual branch July 4, 2015 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants