Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Static analysis doesn't catch `RefCell<Option<DOMException>>` #6651

Closed
jdm opened this issue Jul 17, 2015 · 1 comment
Closed

Static analysis doesn't catch `RefCell<Option<DOMException>>` #6651

jdm opened this issue Jul 17, 2015 · 1 comment
Assignees
@Manishearth
Labels
A-plugins I-safety

Comments

@jdm
Copy link
Member

@jdm jdm commented Jul 17, 2015

cc @Manishearth
@jdm
Copy link
Member Author

@jdm jdm commented Jul 17, 2015

Maybe even just Option<DOMException> is enough if we still don't look at generic types.
@Manishearth Manishearth mentioned this issue Jul 21, 2015
Closed
@Manishearth Manishearth self-assigned this Jul 21, 2015
Manishearth added a commit to Manishearth/servo that referenced this issue Jul 21, 2015
@Manishearth
Make stmt part of unrooted_must_root handle type parameters (fixes se…
f8f3a50 
…rvo#6651)
@Manishearth Manishearth mentioned this issue Jul 21, 2015
Merged
Manishearth added a commit to Manishearth/servo that referenced this issue Jul 21, 2015
@Manishearth
Make stmt part of unrooted_must_root handle type parameters (fixes se…
f6f0a7e 
…rvo#6651)
bors-servo pushed a commit that referenced this issue Jul 22, 2015
bors-servo
Auto merge of #6688 - Manishearth:smarter-root-lint, r=jdm
4510943 
Handle type parameters in unused_must_root

fixes #6651

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6688)
<!-- Reviewable:end -->
bors-servo pushed a commit that referenced this issue Jul 22, 2015
bors-servo
Auto merge of #6688 - Manishearth:smarter-root-lint, r=jdm
Loading status checks…
8a6681b 
Handle type parameters in unused_must_root

fixes #6651

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6688)
<!-- Reviewable:end -->
aweinstock314 added a commit to aweinstock314/servo that referenced this issue Jul 28, 2015
@Manishearth @aweinstock314
Make stmt part of unrooted_must_root handle type parameters (fixes se…
a20cb48 
…rvo#6651)
josiahdaniels added a commit to josiahdaniels/servo that referenced this issue Sep 28, 2015
@Manishearth @josiahdaniels
Make stmt part of unrooted_must_root handle type parameters (fixes se…
edd8095 
…rvo#6651)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Manishearth Manishearth

Labels
A-plugins I-safety
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Handle type parameters in unused_must_root
2 participants
@jdm @Manishearth
You can’t perform that action at this time.