Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ScriptTask::find_iframe a free function #6676

Closed
jdm opened this issue Jul 20, 2015 · 1 comment
Closed

Make ScriptTask::find_iframe a free function #6676

jdm opened this issue Jul 20, 2015 · 1 comment
Labels
A-content/script E-easy I-refactor

Comments

@jdm
Copy link
Member

@jdm jdm commented Jul 20, 2015

It doesn't use its self pointer, so it can just be a helpful utility function in the same file.

Code: components/script/script_task.rs
@Ms2ger
Copy link
Contributor

@Ms2ger Ms2ger commented Jul 21, 2015

Why not make it a method on Document?
@tetsuharuohzeki tetsuharuohzeki mentioned this issue Jul 22, 2015
Merged
aweinstock314 added a commit to aweinstock314/servo that referenced this issue Jul 28, 2015
@boghison @aweinstock314
Fix servo#6676
8d99771
josiahdaniels added a commit to josiahdaniels/servo that referenced this issue Sep 28, 2015
@boghison @josiahdaniels
Fix servo#6676
9fb027b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-content/script E-easy I-refactor
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@jdm @Ms2ger
You can’t perform that action at this time.