Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split actual document object out of content frame tree #6687

Closed
jdm opened this issue Jul 21, 2015 · 1 comment
Closed

Split actual document object out of content frame tree #6687

jdm opened this issue Jul 21, 2015 · 1 comment
Labels
A-content/script I-refactor I-safety

Comments

@jdm
Copy link
Member

@jdm jdm commented Jul 21, 2015

I've been thinking of doing this as part of #5236, but it's been pointed out that Frame contains JS pointers, and Page contains Frame, and we use Rc<Page> objects all over the place without any stack roots.

I propose moving all JS pointers into a hashmap in ScriptTask keyed on the PipelineId, and have the content tree just bee a tree of PipelineId values instead.
@jdm jdm mentioned this issue Jul 21, 2015
Closed
@jdm
Copy link
Member Author

@jdm jdm commented Dec 20, 2016

This happened long ago.
@jdm jdm closed this Dec 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-content/script I-refactor I-safety
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
@jdm
You can’t perform that action at this time.