latest rust-cssparser changes broke servo build

[metajack]

It looks like the python task isn't getting run.

@SimonSapin ?

[SimonSapin]

It turns out I messed up the typo fixed (which is not fixed), but I don’t see any issue with the Python task. (Servo master is failing to build for me for unrelated reasons for now…)

[SimonSapin]

@metajack , could you copy the output you get?

[SimonSapin]

I think I got it. ./configure needs to be run so that Makefile gets re-generated from Makefile.in. How is this kind of change supposed to be handled?

[SimonSapin]

Actually, my Makefile rule for generating Rust code with Python doesn’t work when the source and target directories are not the same. Should this generated file be written in the source directory, or should rustc somehow be told to look for .rs files in the target directory?

[SimonSapin]

I did not mean to close this just yet…

[bzbarsky]

My general opinion is that writing to the source directory is a tool of the devil. ;)

[SimonSapin]

Could rustc do environment variable expansion in #[path]?

#[path = "$TARGET/color_data.rs"]
mod color_data;

[jdm]

#[path] is gone from newer versions of rust.