Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache the Document title #6713

Open
nox opened this issue Jul 23, 2015 · 3 comments
Open

Cache the Document title #6713

nox opened this issue Jul 23, 2015 · 3 comments

Comments

@nox
Copy link
Member

@nox nox commented Jul 23, 2015

Whenever Document.title_changed() is called by the virtual methods on HTMLTitleElement, the tree is traversed to find the first title element in the document and notify the chrome of the change.

The current title element should be cached in Document in a MutNullableHeap<JS<HTMLTitleElement>> field and be updated in bind_from_tree() and unbind_from_tree() in the virtual methods on HTMLTitleElement.

@nox
Copy link
Member Author

@nox nox commented Jul 23, 2015

Cc'ing @nick-thompson who said he was interested in looking into this.

@nick-thompson
Copy link
Contributor

@nick-thompson nick-thompson commented Jul 23, 2015

Thanks, I'm on it!

@frewsxcv
Copy link
Member

@frewsxcv frewsxcv commented Dec 11, 2016

...and be updated in bind_from_tree() and unbind_from_tree() in the virtual methods on HTMLTitleElement

Sinmce an SVG <title> element is (presumably) not an HTMLTitleElement, how will this work in the SVG case?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.