Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract layout query code into a separate file #6787

Closed
jdm opened this issue Jul 27, 2015 · 1 comment
Closed

Extract layout query code into a separate file #6787

jdm opened this issue Jul 27, 2015 · 1 comment
Labels
A-layout/uncategorized C-assigned E-easy I-refactor

Comments

@jdm
Copy link
Member

@jdm jdm commented Jul 27, 2015

layout_task.rs is becoming unwieldy, and will only continue to grow. I propose extracting LayoutRPCImpl, UnioningFragmentBorderBoxIterator, CollectingFragmentBorderBoxIterator, process_content_box_request, and process_content_boxes_request (these two don't use the self argument) into a new file in layout called query.rs.

Code: components/layout/layout_task.rs
@glennw glennw mentioned this issue Jul 27, 2015
Merged
@dzbarsky dzbarsky mentioned this issue Jul 28, 2015
Merged
@nick-thompson nick-thompson mentioned this issue Jul 29, 2015
Merged
@jdm jdm added the C-assigned label Jul 31, 2015
bors-servo pushed a commit that referenced this issue Aug 6, 2015
bors-servo
Auto merge of #6836 - nick-thompson:layout_refactor, r=Ms2ger
Loading status checks…
172f046 
Extract layout query code into layout/query.rs

Fix for #6787. I left the commits split up for ease of review, happy to squash when this gets accepted.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6836)
<!-- Reviewable:end -->
@wafflespeanut
Copy link
Member

@wafflespeanut wafflespeanut commented Aug 15, 2015

@jdm This can be closed :)
@jdm jdm closed this Aug 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-layout/uncategorized C-assigned E-easy I-refactor
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@jdm @wafflespeanut
You can’t perform that action at this time.