Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update and re-enable CSS tests that use 4 digit colors #6856

Closed
metajack opened this issue Jul 30, 2015 · 5 comments
Closed

update and re-enable CSS tests that use 4 digit colors #6856

metajack opened this issue Jul 30, 2015 · 5 comments
Labels

Comments

@metajack
Copy link
Contributor

@metajack metajack commented Jul 30, 2015

After landing servo/rust-cssparser#80 the following tests started failing incorrectly:

/css21_dev/html4/border-bottom-color-030.htm
/css21_dev/html4/border-left-color-030.htm
/css21_dev/html4/border-right-color-030.htm
/css21_dev/html4/border-top-color-030.htm

These tests need to be updated upstream. Then Servo needs to update the CSS tests and re-enable these.

metajack added a commit to metajack/servo that referenced this issue Jul 30, 2015
metajack added a commit to metajack/servo that referenced this issue Jul 30, 2015
This also updates wpt tests for new CSS Level 4 color parsing, and
disables the relevant CSS tests until they can be updated (tracked
by servo#6856).
@metajack
Copy link
Contributor Author

@metajack metajack commented Jul 30, 2015

Upstream pull request to update tests: w3c/csswg-test#814

metajack added a commit to metajack/servo that referenced this issue Jul 30, 2015
This also updates wpt tests for new CSS Level 4 color parsing, and
disables the relevant CSS tests until they can be updated (tracked
by servo#6856).
@ghost
Copy link

@ghost ghost commented Jul 31, 2015

Hi, I would like to work on this bug could someone help me out ?

@metajack
Copy link
Contributor Author

@metajack metajack commented Jul 31, 2015

I already submitted a patch w3c/csswg-test#814 but looks like it won't be accepted. I'm not sure what the next steps are.

@Ms2ger @jgraham thoughts?

@jdm jdm removed the E-easy label Jul 31, 2015
@SimonSapin
Copy link
Member

@SimonSapin SimonSapin commented Aug 25, 2015

Tests should allow either behavior: w3c/csswg-test#831 (comment)

josiahdaniels added a commit to josiahdaniels/servo that referenced this issue Sep 28, 2015
This also updates wpt tests for new CSS Level 4 color parsing, and
disables the relevant CSS tests until they can be updated (tracked
by servo#6856).
@nox
Copy link
Member

@nox nox commented Sep 30, 2017

These tests don't seem disabled to me anymore.

@nox nox closed this Sep 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.