Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build servo on travis #6962

Closed
frewsxcv opened this issue Aug 4, 2015 · 10 comments
Closed

Build servo on travis #6962

frewsxcv opened this issue Aug 4, 2015 · 10 comments
Assignees

Comments

@frewsxcv
Copy link
Member

@frewsxcv frewsxcv commented Aug 4, 2015

Right now, travis just executes mach make-tidy

Is there any reason we don't have travis also build servo? It seems like that could reduce some of the churn for pull requests that fail to compile immediately after they get r+'d.

rust-lang/rust recently updated their travis config to compile stage1

@metajack
Copy link
Contributor

@metajack metajack commented Aug 4, 2015

Travis can't reliably build mozjs. It doesn't have enough memory.

@frewsxcv
Copy link
Member Author

@frewsxcv frewsxcv commented Aug 4, 2015

Ah, that's unfortunate. I didn't know building mozjs consumed >3GB of memory :(

The only solution I can think of would be to publish servo/mozjs to crates.io, which might not be desirable? If publishing it isn ot desirable, and you don't think this issue can be completed realistically, then this issue can be closed.

@metajack
Copy link
Contributor

@metajack metajack commented Aug 4, 2015

How does crates.io help here? It does not store binary packages just metadata.

@frewsxcv
Copy link
Member Author

@frewsxcv frewsxcv commented Aug 4, 2015

Blah, sorry, you're right (I blame my jet lag). Never mind that then

@frewsxcv
Copy link
Member Author

@frewsxcv frewsxcv commented Aug 5, 2015

For what it's worth, I was curious if anyone in #jsapi on Mozilla IRC had any suggestions on reducing memory during compilation:

2:25 PM frewsxcv: I'd suggest reducing NUM_JOBS first then
2:26 PM frewsxcv: Another thing that might work is to reduce MOZ_FILES_PER_UNIFIED_FILE, though you might get compilation errors if any non-unified bustage has slipped in
2:31 PM frewsxcv: Other than using less optimizations, that is (-O1 or -Os probably use a lot less memory during compilation)

@frewsxcv
Copy link
Member Author

@frewsxcv frewsxcv commented Oct 7, 2015

Now that servo/mozjs#57 has merged, I'll look into this later today

@frewsxcv frewsxcv self-assigned this Oct 7, 2015
@metajack
Copy link
Contributor

@metajack metajack commented Oct 7, 2015

rust-mozjs would be the logically next step :)

@frewsxcv
Copy link
Member Author

@frewsxcv frewsxcv commented Oct 7, 2015

There's currently already a Travis config file, though it appears it might be turned off (considering it hasn't built in a while)?

https://github.com/servo/rust-mozjs/blob/master/.travis.yml

https://travis-ci.org/servo/rust-mozjs/branches

@jdm
Copy link
Member

@jdm jdm commented Oct 7, 2015

Yes, the travis service is turned off. If you have the power to do so, feel free to enable it, or let one of us know when it's the right time.

@frewsxcv
Copy link
Member Author

@frewsxcv frewsxcv commented Oct 8, 2015

Opened a PR: #7915

bors-servo pushed a commit that referenced this issue Oct 8, 2015
Build Servo on Travis

Closes #6962

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7915)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.