Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement some of the IDL attributes for input #7004

Closed
farodin91 opened this issue Aug 5, 2015 · 5 comments
Closed

Implement some of the IDL attributes for input #7004

farodin91 opened this issue Aug 5, 2015 · 5 comments
Labels

Comments

@farodin91
Copy link
Contributor

@farodin91 farodin91 commented Aug 5, 2015

Spec: https://www.whatwg.org/html/#htmlinputelement
Code: components/script/dom/webidls/HTMLInputElement.webidl, components/script/dom/htmlinputelement.rs

@farodin91
Copy link
Contributor Author

@farodin91 farodin91 commented Sep 1, 2015

Are there any important attributes that aren't implemented if not I will look into validations

@farodin91
Copy link
Contributor Author

@farodin91 farodin91 commented Sep 3, 2015

@jdm ?

@jdm
Copy link
Member

@jdm jdm commented Sep 8, 2015

I apologize for the long wait here. I was hoping to use form validation as a project for some students at NCSU this semester, but it's fine if you've already started working on it; I can find another.

@farodin91
Copy link
Contributor Author

@farodin91 farodin91 commented Sep 8, 2015

Currently I working on other things. If you want use this as a student project, I can find other issues.

samfoo added a commit to samfoo/servo that referenced this issue Sep 12, 2015
samfoo added a commit to samfoo/servo that referenced this issue Sep 15, 2015
samfoo added a commit to samfoo/servo that referenced this issue Sep 17, 2015
samfoo added a commit to samfoo/servo that referenced this issue Sep 19, 2015
samfoo added a commit to samfoo/servo that referenced this issue Sep 27, 2015
samfoo added a commit to samfoo/servo that referenced this issue Sep 29, 2015
samfoo added a commit to samfoo/servo that referenced this issue Oct 2, 2015
samfoo added a commit to samfoo/servo that referenced this issue Oct 8, 2015
samfoo added a commit to samfoo/servo that referenced this issue Dec 2, 2015
bors-servo added a commit that referenced this issue Dec 3, 2015
Adds support for input element's maxlength attr

This implements maxlength [as described by whatwg](https://html.spec.whatwg.org/multipage/forms.html#dom-input-maxlength) for input elements.

Remaining work:
* WPT test - I have no idea how to write a WPT for simulating user input. Webdriver? Open to suggestions here.
* Support for textarea (should be trivial, probably worth filing another issue)

#7320
#7004

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7323)
<!-- Reviewable:end -->
samfoo added a commit to samfoo/servo that referenced this issue Dec 3, 2015
bors-servo added a commit that referenced this issue Dec 3, 2015
Adds support for input element's maxlength attr

This implements maxlength [as described by whatwg](https://html.spec.whatwg.org/multipage/forms.html#dom-input-maxlength) for input elements.

Remaining work:
* WPT test - I have no idea how to write a WPT for simulating user input. Webdriver? Open to suggestions here.
* Support for textarea (should be trivial, probably worth filing another issue)

#7320
#7004

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7323)
<!-- Reviewable:end -->
jrmuizel pushed a commit to jrmuizel/gecko-cinnabar that referenced this issue Jun 12, 2017
…(from samfoo:input-maxlength); r=jdm

This implements maxlength [as described by whatwg](https://html.spec.whatwg.org/multipage/forms.html#dom-input-maxlength) for input elements.

Remaining work:
* WPT test - I have no idea how to write a WPT for simulating user input. Webdriver? Open to suggestions here.
* Support for textarea (should be trivial, probably worth filing another issue)

servo/servo#7320
servo/servo#7004

Source-Repo: https://github.com/servo/servo
Source-Revision: fc3e950052b6cc580dc32fc03d978fad97b49ba8
@nox
Copy link
Member

@nox nox commented Sep 30, 2017

Most attributes are implemented now.

@nox nox closed this Sep 30, 2017
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this issue Oct 1, 2019
…(from samfoo:input-maxlength); r=jdm

This implements maxlength [as described by whatwg](https://html.spec.whatwg.org/multipage/forms.html#dom-input-maxlength) for input elements.

Remaining work:
* WPT test - I have no idea how to write a WPT for simulating user input. Webdriver? Open to suggestions here.
* Support for textarea (should be trivial, probably worth filing another issue)

servo/servo#7320
servo/servo#7004

Source-Repo: https://github.com/servo/servo
Source-Revision: fc3e950052b6cc580dc32fc03d978fad97b49ba8

UltraBlame original commit: b43c7b497f1c48fcd2887144ff51f98b5f2df619
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this issue Oct 1, 2019
…(from samfoo:input-maxlength); r=jdm

This implements maxlength [as described by whatwg](https://html.spec.whatwg.org/multipage/forms.html#dom-input-maxlength) for input elements.

Remaining work:
* WPT test - I have no idea how to write a WPT for simulating user input. Webdriver? Open to suggestions here.
* Support for textarea (should be trivial, probably worth filing another issue)

servo/servo#7320
servo/servo#7004

Source-Repo: https://github.com/servo/servo
Source-Revision: fc3e950052b6cc580dc32fc03d978fad97b49ba8

UltraBlame original commit: b43c7b497f1c48fcd2887144ff51f98b5f2df619
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this issue Oct 1, 2019
…(from samfoo:input-maxlength); r=jdm

This implements maxlength [as described by whatwg](https://html.spec.whatwg.org/multipage/forms.html#dom-input-maxlength) for input elements.

Remaining work:
* WPT test - I have no idea how to write a WPT for simulating user input. Webdriver? Open to suggestions here.
* Support for textarea (should be trivial, probably worth filing another issue)

servo/servo#7320
servo/servo#7004

Source-Repo: https://github.com/servo/servo
Source-Revision: fc3e950052b6cc580dc32fc03d978fad97b49ba8

UltraBlame original commit: b43c7b497f1c48fcd2887144ff51f98b5f2df619
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.