Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upConvert the units used in the PaintContext struct to use typed units. #7023
Labels
Comments
|
I'd like to try this one. As I understand, I have to change Rect to TypedRect for screen and page:
And then convert units. Am I right? |
|
Yes, that's correct. |
mskrzypkows
pushed a commit
to mskrzypkows/servo
that referenced
this issue
Oct 28, 2015
Needs update to_nearest_pixel method in app_unit module. Argument of to_nearest_pixel should be: ScaleFactor<PagePx, ScreenPx, f32>
mskrzypkows
pushed a commit
to mskrzypkows/servo
that referenced
this issue
Oct 30, 2015
Needs update to_nearest_pixel method in app_unit module. Argument of to_nearest_pixel should be: ScaleFactor<PagePx, ScreenPx, f32>
mskrzypkows
pushed a commit
to mskrzypkows/servo
that referenced
this issue
Nov 4, 2015
Needs update to_nearest_pixel method in app_unit module. Argument of to_nearest_pixel should be: ScaleFactor<PagePx, ScreenPx, f32>
bors-servo
added a commit
that referenced
this issue
Nov 6, 2015
Draft. Change PaintContext rects to TypedRects #7023 I created draft. I'm not sure if we need any units conversion in PaintContext. There is also strange 'clear' method, we use PagePx origin and ScreenPx size is it OK? <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7696) <!-- Reviewable:end -->
bors-servo
added a commit
that referenced
this issue
Nov 6, 2015
Draft. Change PaintContext rects to TypedRects #7023 I created draft. I'm not sure if we need any units conversion in PaintContext. There is also strange 'clear' method, we use PagePx origin and ScreenPx size is it OK? <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7696) <!-- Reviewable:end -->
|
Closing this since PaintContext was removed in fdf9312. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
To avoid retina display related bugs.