test-wpt fails with servodriver

[metajack]

STR: ./mach test-wpt --release --product servodriver

EnvironmentError: http server on port 8000 failed to start

  File "/Users/jack/src/servo/python/servo/testing_commands.py", line 250, in test_wpt
    return run_globals["run_tests"](**kwargs)
  File "/Users/jack/src/servo/tests/wpt/run_wpt.py", line 13, in run_tests
    return run.run_tests(paths=paths, **kwargs)
  File "/Users/jack/src/servo/tests/wpt/run.py", line 28, in run_tests
    success = wptrunner.run_tests(**kwargs)
  File "/Users/jack/src/servo/tests/wpt/harness/wptrunner/wptrunner.py", line 147, in run_tests
    test_environment.ensure_started()
  File "/Users/jack/src/servo/tests/wpt/harness/wptrunner/environment.py", line 242, in ensure_started
    "%s server on port %d failed to start" % (scheme, port))

cc @jgraham

[SimonSapin]

An earlier bit of the output seems relevant:

 0:10.05 LOG: Thread-Log INFO STDERR: Socket error on port 8888
 0:10.06 LOG: Thread-Log INFO STDERR: Socket error on port 48006
 0:10.07 LOG: MainThread wptserve WARNING Init failed! You may need to modify your hosts file. Refer to README.md.
 0:10.07 LOG: Thread-Log INFO STDERR: Socket error on port 8000
 0:10.08 LOG: MainThread wptserve WARNING Init failed! You may need to modify your hosts file. Refer to README.md.
 0:10.08 LOG: Thread-Log INFO STDERR: Socket error on port 8001
 0:10.08 LOG: MainThread wptserve WARNING Init failed! You may need to modify your hosts file. Refer to README.md.
 0:10.08 LOG: Thread-Log INFO STDERR: Socket error on port 8443

[metajack]

Why do I need to do this when running then via mach? The README doesn't list that except for when you are running manually.

[metajack]

I also get this on the macpro:

administrators-Mac-Pro:servo-test servo$ ./mach test-wpt --release --product servodriver
Error running mach:

    ['test-wpt', '--release', '--product', 'servodriver']

The error occurred in code that was called by the mach command. This is either
a bug in the called code itself or in the way that mach is calling it.

You should consider filing a bug for this issue.

If filing a bug, please include the full output of mach, including this error
message.

The details of the failure are as follows:

AttributeError: 'module' object has no attribute 'setup_logging'

  File "/Users/servo/servo-test/python/servo/testing_commands.py", line 250, in test_wpt
    return run_globals["run_tests"](**kwargs)
  File "/Users/servo/servo-test/tests/wpt/run_wpt.py", line 13, in run_tests
    return run.run_tests(paths=paths, **kwargs)
  File "/Users/servo/servo-test/tests/wpt/run.py", line 27, in run_tests
    wptrunner.setup_logging(kwargs, {"mach": sys.stdout})

[metajack]

Adding the hosts lines does cause the tests to start working, but this seems bad.

[jgraham]

I'm looking into this.

The hosts line bug is easy to fix, it's just some missing configuration in the harness. For me every test is crashing, which seems bad.

[metajack]

Yes, I am noticing crashes as well, but perhaps not every test. But many :)

[metajack]

From @jgraham in IRC:

So the crash I see is because the initial navigation is calling ScriptTask::handle_freeze_message which calls ScriptTask::root_page() whilst the root page is None, which then panics. If I just return early from that method when there is no root page servo driver works locally for me.

[metajack]

So part of this was caused by my upgrading the wptrunner without the corresponding upgrade to mozlog or some similar combination. I need to retest now that those have both been properly upgraded.

[jgraham]

Yeah, you need that upgrade and then a fix for the race between the initial page load and the navigation mentioned above.