/servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement WebSocket#binaryType. #7098

Closed
Ms2ger opened this Issue Aug 8, 2015 · 3 comments

Comments

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
3 participants
@Ms2ger @tomjakubowski @jdm
@Ms2ger
Contributor

Ms2ger commented Aug 8, 2015

Blocks #6060

@Ms2ger Ms2ger added A-content/dom E-easy I-enhancement labels Aug 8, 2015

@tomjakubowski

This comment has been minimized.

Show comment
Hide comment
@tomjakubowski

tomjakubowski Aug 9, 2015

Contributor

I can take a stab at this.
Contributor

tomjakubowski commented Aug 9, 2015

I can take a stab at this.
@jdm

This comment has been minimized.

Show comment
Hide comment
@jdm

jdm Aug 9, 2015

Member

Please do!
Member

jdm commented Aug 9, 2015

Please do!

@jdm jdm added the C-assigned label Aug 9, 2015

tomjakubowski added a commit to tomjakubowski/servo that referenced this issue Aug 13, 2015

@tomjakubowski
WebSocket: add binaryType DOM accessor 
Doesn't do as the spec says, waiting on a safe ArrayBuffer wrapper to
land.

part of #7098
8d999de
@tomjakubowski

This comment has been minimized.

Show comment
Hide comment
@tomjakubowski

tomjakubowski Aug 13, 2015

Contributor

I did the bare minimum and enabled the attribute in the IDL file and added the necessary fields and impl methods. See tomjakubowski@8d999de

It doesn't actually change the type of the data provided to the message callback, however, because I couldn't see an immediate and obvious safe way to create and return an ArrayBuffer (which should apparently land as part of #6779).
Contributor

tomjakubowski commented Aug 13, 2015

I did the bare minimum and enabled the attribute in the IDL file and added the necessary fields and impl methods. See tomjakubowski@8d999de

It doesn't actually change the type of the data provided to the message callback, however, because I couldn't see an immediate and obvious safe way to create and return an ArrayBuffer (which should apparently land as part of #6779).

@tomjakubowski tomjakubowski referenced this issue Aug 14, 2015

Merged

Implement WebSocket#binaryType #7214

bors-servo pushed a commit that referenced this issue Aug 15, 2015

bors-servo
Auto merge of #7214 - tomjakubowski:websocket-binaryType, r=Ms2ger 
Implement WebSocket#binaryType

Closes #7098

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7214)
<!-- Reviewable:end -->
311dea8

bors-servo pushed a commit that referenced this issue Aug 16, 2015

bors-servo
Auto merge of #7214 - tomjakubowski:websocket-binaryType, r=Ms2ger 
Implement WebSocket#binaryType

Closes #7098

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7214)
<!-- Reviewable:end -->
7c63c7d

@bors-servo bors-servo closed this in #7214 Aug 16, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment