Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

`make tidy` should ensure that we do not have two versions of the same package in Cargo.lock #7133

Closed
larsbergstrom opened this issue Aug 10, 2015 · 1 comment

Comments

@larsbergstrom
Copy link
Contributor

@larsbergstrom larsbergstrom commented Aug 10, 2015

While permitted by Cargo, it's always an error in Servo to have multiple versions of the same package. make tidy should check each of the Cargo.lock files to ensure that no dependency is included twice at different versions.

@larsbergstrom
Copy link
Contributor Author

@larsbergstrom larsbergstrom commented Aug 10, 2015

Note that a related feature has been under discussion in Cargo for at least a year, but it's not clear what the path forward is on it: rust-lang/cargo#73

bors-servo pushed a commit that referenced this issue Sep 1, 2015
Tidy can now check for version conflicts...

fixes #7133

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7438)
<!-- Reviewable:end -->
@Ms2ger Ms2ger removed the A-cargo label Jan 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants
You can’t perform that action at this time.