Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

physics demo performance on android #7135

Open
metajack opened this issue Aug 10, 2015 · 7 comments
Open

physics demo performance on android #7135

metajack opened this issue Aug 10, 2015 · 7 comments
Assignees

Comments

@metajack
Copy link
Contributor

@metajack metajack commented Aug 10, 2015

Currently the physics demo works on desktop and android, but the performance on Android is quite low, although still better than Chrome.

We need to investigate and potentially optimize this.

Note that the framerate counter is offscreen in Servo and can be fixed by adding left: 100px; top: 100px to the #fps rule in the CSS.

@gordonbrander
Copy link

@gordonbrander gordonbrander commented Aug 10, 2015

Note that the framerate counter is offscreen in Servo and can be fixed by adding left: 100px; top: 100px to the #fps rule in the CSS.

@metajack What about left: 0; top: 0;? The initial location of absolute elements is typically where they would have ended up in the flow. If this does not yet work in Servo, left: 0; top: 0; should pin the counter to the top left which is where it lives on other browsers.

@gordonbrander
Copy link

@gordonbrander gordonbrander commented Aug 10, 2015

Currently the physics demo works on desktop and android, but the performance on Android is quite low, although still better than Chrome.

If we are constrained by the HW, we can reduce the number of particles, or add a toggle that lets us define a workload size.

@metajack
Copy link
Contributor Author

@metajack metajack commented Aug 10, 2015

@gordonbrander I think the issue with left and top is that left: 0 and top: 0 are under the Android system toolbar, so it can't be seen. That's a bug in Servo we should probably fix.

Also I needed to add --device-pixel-ratio 2.0 to the hardcoded startup args for the G Pad since it's high res.

We hit about 60fps around 25 particles, but we are better than Chrome at most points I measured (1000, 500, 250, 125 and the original 1500). Our performance feels more uneven (lots of 7fps followed by 60fps avging to 20, etc).

@metajack
Copy link
Contributor Author

@metajack metajack commented Aug 13, 2015

@pcwalton discovered that Skia was not being built with ARM NEON optimizations at all. Working on a fix for that.

@metajack
Copy link
Contributor Author

@metajack metajack commented Aug 13, 2015

@metajack
Copy link
Contributor Author

@metajack metajack commented Aug 14, 2015

servo/skia#66 has landed, but made little difference in the demos unfortunately. More investigation is needed.

@CYBAI
Copy link
Collaborator

@CYBAI CYBAI commented Dec 15, 2018

Got slow perf with the physics demo on my MBP with latest master (c9229f3).
And the dots even don't move 😂

default

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.