Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

files in `ports/cef/` should get linted #7202

Closed
frewsxcv opened this issue Aug 13, 2015 · 5 comments
Closed

files in `ports/cef/` should get linted #7202

frewsxcv opened this issue Aug 13, 2015 · 5 comments
Labels

Comments

@frewsxcv
Copy link
Member

@frewsxcv frewsxcv commented Aug 13, 2015

It is marked as being 'upstream' (which is not the case as far as I know) so we currently don't lint it

Steps to complete this:

  1. Delete this line
  2. Clean up all tidy issues brought up by ./mach test-tidy
@jdm
Copy link
Member

@jdm jdm commented Aug 13, 2015

The vast majority of the code is automatically generated, and we can't just replace the license because it's generated from the CEF C++ header. I don't think this is worth the effort.

@jdm jdm closed this Aug 13, 2015
@frewsxcv
Copy link
Member Author

@frewsxcv frewsxcv commented Aug 13, 2015

Sounds good. Just for my own knowledge, the only code that is autogenerated lives in ports/cef/interfaces/, right? As opposed to all the *.rs files in ports/cef/

@jdm
Copy link
Member

@jdm jdm commented Aug 13, 2015

That does seem to be the case, from my brief poking around.

@zmike
Copy link
Contributor

@zmike zmike commented Aug 14, 2015

That's correct.

@SimonSapin
Copy link
Member

@SimonSapin SimonSapin commented Dec 2, 2015

When changing the ignored pattern from ports/cef/* to ports/cef/interfaces/*, mach test-tidy currently gives 365 lines of output. Most of it is about whitespace. An extract:

./ports/cef/types.rs:31: missing space before =
./ports/cef/types.rs:31: missing space after =
./ports/cef/types.rs:772: missing space before =
./ports/cef/types.rs:772: missing space after =
./ports/cef/types.rs:810: missing space before =
./ports/cef/types.rs:810: missing space after =
./ports/cef/wrappers.rs:15: Line is longer than 120 characters
./ports/cef/wrappers.rs:36: encountered whitespace following a use statement
./ports/cef/wrappers.rs:196: missing space after ,
./ports/cef/wrappers.rs:197: missing space after ,
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.