Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a PerformanceActor. #7234

Merged
merged 1 commit into from Aug 15, 2015
Merged

Conversation

Ms2ger
Copy link
Contributor

@Ms2ger Ms2ger commented Aug 15, 2015

This is necessary for the devtools "Start Recording Performance" button to
send a message.

(This message is not yet supported, so it leads to
'unexpected message type "startRecording" found for actor "performance4"'.)

Review on Reviewable

This is necessary for the devtools "Start Recording Performance" button to
send a message.

(This message is not yet supported, so it leads to
'unexpected message type "startRecording" found for actor "performance4"'.)
@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Aug 15, 2015
@metajack
Copy link
Contributor

@bors-servo r+


Reviewed 3 of 3 files at r1.
Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.


Comments from the review on Reviewable.io

@bors-servo
Copy link
Contributor

📌 Commit 238beec has been approved by metajack

@bors-servo
Copy link
Contributor

⌛ Testing commit 238beec with merge 0080d0d...

@highfive highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Aug 15, 2015
bors-servo pushed a commit that referenced this pull request Aug 15, 2015
Implement a PerformanceActor.

This is necessary for the devtools "Start Recording Performance" button to
send a message.

(This message is not yet supported, so it leads to
'unexpected message type "startRecording" found for actor "performance4"'.)

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7234)
<!-- Reviewable:end -->
@highfive highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Aug 15, 2015
@bors-servo
Copy link
Contributor

☀️ Test successful - android, gonk, linux1, linux2, mac1, mac2, mac3

@bors-servo bors-servo merged commit 238beec into servo:master Aug 15, 2015
@Ms2ger Ms2ger deleted the PerformanceActor branch August 15, 2015 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants