Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upInterpolation of Calc values is broken #7284
Comments
|
(This will be an issue after #7185 lands) |
|
I'd be happy to take this one. |
|
Great, I'll let you know when that PR lands. |
|
@notriddle you can work on this now if you're still interested |
|
Yup, still interested. On Wed, Sep 9, 2015 at 8:56 PM David Zbarsky notifications@github.com
|
|
I added something that I think will work (manual testing bears this out), but how should I add it to the test suite? |
|
I guess we don't have transitionend events yet but you could do a 0s-length transition and check that the final value matches a reference? Might need to rAF to get it to paint the end state. |
Add transitions for CSS `calc()`. Closes #7284 <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7653) <!-- Reviewable:end -->
Closes servo#7284
In components/style/animation.rs, we have code for interpolating lengths.
The Interpolate impl for LengthOrPercentage and LengthOrPercentageOrAuto (and possibly others, wherever Calc is an enum option) should handle LengthOrPercentage::Calc by interpolating the absolute component and the percentage and then combining them.
E-easy? Happy to mentor.