Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interpolation of Calc values is broken #7284

Closed
dzbarsky opened this issue Aug 19, 2015 · 7 comments
Closed

Interpolation of Calc values is broken #7284

dzbarsky opened this issue Aug 19, 2015 · 7 comments
Labels

Comments

@dzbarsky
Copy link
Member

@dzbarsky dzbarsky commented Aug 19, 2015

In components/style/animation.rs, we have code for interpolating lengths.

The Interpolate impl for LengthOrPercentage and LengthOrPercentageOrAuto (and possibly others, wherever Calc is an enum option) should handle LengthOrPercentage::Calc by interpolating the absolute component and the percentage and then combining them.

E-easy? Happy to mentor.

@dzbarsky
Copy link
Member Author

@dzbarsky dzbarsky commented Aug 19, 2015

(This will be an issue after #7185 lands)

@notriddle
Copy link
Contributor

@notriddle notriddle commented Aug 19, 2015

I'd be happy to take this one.

@dzbarsky
Copy link
Member Author

@dzbarsky dzbarsky commented Aug 19, 2015

Great, I'll let you know when that PR lands.

@dzbarsky
Copy link
Member Author

@dzbarsky dzbarsky commented Sep 10, 2015

@notriddle you can work on this now if you're still interested

@jdm jdm added the A-content/css label Sep 10, 2015
@notriddle
Copy link
Contributor

@notriddle notriddle commented Sep 10, 2015

Yup, still interested.

On Wed, Sep 9, 2015 at 8:56 PM David Zbarsky notifications@github.com
wrote:

@notriddle https://github.com/notriddle you can work on this now if
you're still interested


Reply to this email directly or view it on GitHub
#7284 (comment).

@notriddle
Copy link
Contributor

@notriddle notriddle commented Sep 10, 2015

I added something that I think will work (manual testing bears this out), but how should I add it to the test suite?

@dzbarsky
Copy link
Member Author

@dzbarsky dzbarsky commented Sep 16, 2015

I guess we don't have transitionend events yet but you could do a 0s-length transition and check that the final value matches a reference? Might need to rAF to get it to paint the end state.

bors-servo pushed a commit that referenced this issue Sep 20, 2015
Add transitions for CSS `calc()`.

Closes #7284

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7653)
<!-- Reviewable:end -->
josiahdaniels added a commit to josiahdaniels/servo that referenced this issue Sep 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.