Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Links for results don't show up when searching Google #7298

Closed
FreeFull opened this issue Aug 20, 2015 · 5 comments
Closed

Links for results don't show up when searching Google #7298

FreeFull opened this issue Aug 20, 2015 · 5 comments
Labels
A-content/dom I-bustage

Comments

@FreeFull
Copy link
Contributor

@FreeFull FreeFull commented Aug 20, 2015

servo bug
@pcwalton
Copy link
Contributor

@pcwalton pcwalton commented Aug 21, 2015

Yeah, I looked briefly into this and it looks like a DOM problem.
@jdm
Copy link
Member

@jdm jdm commented Aug 22, 2015

Is there any interesting output from stdout/stderr?
@FreeFull
Copy link
Contributor Author

@FreeFull FreeFull commented Aug 23, 2015

No interesting output, just a few javascript errors.

Edit: For reference

ERROR:js::rust: Error at https://apis.google.com/_/scs/abc-static/_/js/k=gapi.gapi.en.vwFhyajD8zA.O/m=gapi_iframes,googleapis_client,plusone/rt=j/sv=1/d=1/ed=1/am=AAI/rs=AItRSTPOWGI_kROKlKX9NGLO-MOVVH8_gQ/cb=gapi.loaded_0:200: TypeError: qa.lb is not a function

ERROR:js::rust: Error at https://www.google.co.uk/?gfe_rd=cr&ei=EFTZVc3ZCI6x8weU2J3wDQ:0: ReferenceError: q is not defined

ERROR:js::rust: Error at https://apis.google.com/_/scs/abc-static/_/js/k=gapi.gapi.en.vwFhyajD8zA.O/m=gapi_iframes,googleapis_client,plusone/rt=j/sv=1/d=1/ed=1/am=AAI/rs=AItRSTPOWGI_kROKlKX9NGLO-MOVVH8_gQ/cb=gapi.loaded_0:200: TypeError: qa.lb is not a function
@jdm
Copy link
Member

@jdm jdm commented Aug 23, 2015

The JS errors are the interesting part.
@FreeFull
Copy link
Contributor Author

@FreeFull FreeFull commented Aug 23, 2015

I believe those were there back when the google results page was working, too.
pcwalton added a commit to pcwalton/servo that referenced this issue Sep 5, 2015
@pcwalton
layout: Defend the block formatting context speculation against going…
ded4a57 
… wrong in

the presence of blocks that overflow in the inline direction.

Makes the Google search result links appear.

Closes servo#7298.
@pcwalton pcwalton mentioned this issue Sep 5, 2015
Merged
bors-servo pushed a commit that referenced this issue Sep 11, 2015
bors-servo
Auto merge of #7550 - pcwalton:block-formatting-context-overflow, r=m…
Loading status checks…
c3f9e18 
…brubeck

layout: Defend the block formatting context speculation against going wrong in the presence of blocks that overflow in the inline direction.

Makes the Google search result links appear.

Closes #7298.

r? @mbrubeck

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7550)
<!-- Reviewable:end -->
josiahdaniels added a commit to josiahdaniels/servo that referenced this issue Sep 28, 2015
@pcwalton @josiahdaniels
layout: Defend the block formatting context speculation against going…
df946a1 
… wrong in

the presence of blocks that overflow in the inline direction.

Makes the Google search result links appear.

Closes servo#7298.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-content/dom I-bustage
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@jdm @pcwalton @FreeFull
You can’t perform that action at this time.