Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support <br clear="foo"> #7311

Open
mdinger opened this issue Aug 21, 2015 · 8 comments
Open

Support <br clear="foo"> #7311

mdinger opened this issue Aug 21, 2015 · 8 comments
Labels
A-layout/inline

Comments

@mdinger
Copy link

@mdinger mdinger commented Aug 21, 2015

Testcase:

<html><head>
<style>
.test { float:left; }
</style>
</head>

<body>
<div><img class="test" src="https://www.google.com/images/srpr/logo11w.png" height="90" width="90"></div>
<br clear="left">
</div>

<div class="test"><img src="https://www.google.com/images/srpr/logo11w.png" height="90" width="90"></div>
</body></html>

causes:
misalign

[EDIT]
Problematic in http://www.dota2.com/hero/Earthshaker/ . These pages look pretty messy in general
@mdinger
Copy link
Author

@mdinger mdinger commented Aug 21, 2015

Updated OP with a linked testcase.
@pcwalton pcwalton changed the title testcase is misaligned in servo Support <br clear="foo"> Aug 21, 2015
@pcwalton
Copy link
Contributor

@pcwalton pcwalton commented Aug 21, 2015

Thanks for the test! Updated the title with the problem.
@pcwalton
Copy link
Contributor

@pcwalton pcwalton commented Aug 21, 2015

Unfortunately I don't see a spec for this attribute.
@mdinger
Copy link
Author

@mdinger mdinger commented Aug 21, 2015

Would it be this?

EDIT: Oops, that's not the same. I'm really bad with html.

EDIT: Mozilla states it is deprecated. I think the original spec seems to be here though.
@Ms2ger
Copy link
Contributor

@Ms2ger Ms2ger commented Aug 22, 2015

https://html.spec.whatwg.org/multipage/rendering.html#phrasing-content-3
@jdm jdm added the A-layout/inline label Aug 23, 2015
@mdinger
Copy link
Author

@mdinger mdinger commented Aug 27, 2015

Oh, this is problematic for a website like http://www.dota2.com/hero/Earthshaker/ which renders pretty badly in general on servo.
@frewsxcv frewsxcv mentioned this issue Dec 13, 2015
Open
@mdinger
Copy link
Author

@mdinger mdinger commented Jan 30, 2016

Still a problem with commit 3165781
@shinglyu shinglyu mentioned this issue Feb 6, 2017
Open
@jdm
Copy link
Member

@jdm jdm commented Mar 16, 2017 •
edited

resources/presentational-hints.css includes the br rules from https://html.spec.whatwg.org/multipage/rendering.html#phrasing-content-3, so this is the layout code implementing clear behaviour not working correctly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-layout/inline
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
@jdm @Ms2ger @pcwalton @mdinger
You can’t perform that action at this time.