Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement "maxlength" attribute for text input #7320

Closed
samfoo opened this issue Aug 23, 2015 · 0 comments
Closed

Implement "maxlength" attribute for text input #7320

samfoo opened this issue Aug 23, 2015 · 0 comments
Labels

Comments

@samfoo
Copy link
Contributor

@samfoo samfoo commented Aug 23, 2015

Pulling apart #7004 a bit.

This is a placeholder for an upcoming pull request.

samfoo added a commit to samfoo/servo that referenced this issue Aug 23, 2015
@jdm jdm added the A-content/dom label Aug 23, 2015
samfoo added a commit to samfoo/servo that referenced this issue Aug 23, 2015
samfoo added a commit to samfoo/servo that referenced this issue Sep 1, 2015
samfoo added a commit to samfoo/servo that referenced this issue Sep 12, 2015
samfoo added a commit to samfoo/servo that referenced this issue Sep 15, 2015
samfoo added a commit to samfoo/servo that referenced this issue Sep 17, 2015
samfoo added a commit to samfoo/servo that referenced this issue Sep 19, 2015
samfoo added a commit to samfoo/servo that referenced this issue Sep 27, 2015
samfoo added a commit to samfoo/servo that referenced this issue Sep 29, 2015
samfoo added a commit to samfoo/servo that referenced this issue Oct 2, 2015
samfoo added a commit to samfoo/servo that referenced this issue Oct 8, 2015
samfoo added a commit to samfoo/servo that referenced this issue Dec 2, 2015
bors-servo added a commit that referenced this issue Dec 3, 2015
Adds support for input element's maxlength attr

This implements maxlength [as described by whatwg](https://html.spec.whatwg.org/multipage/forms.html#dom-input-maxlength) for input elements.

Remaining work:
* WPT test - I have no idea how to write a WPT for simulating user input. Webdriver? Open to suggestions here.
* Support for textarea (should be trivial, probably worth filing another issue)

#7320
#7004

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7323)
<!-- Reviewable:end -->
samfoo added a commit to samfoo/servo that referenced this issue Dec 3, 2015
bors-servo added a commit that referenced this issue Dec 3, 2015
Adds support for input element's maxlength attr

This implements maxlength [as described by whatwg](https://html.spec.whatwg.org/multipage/forms.html#dom-input-maxlength) for input elements.

Remaining work:
* WPT test - I have no idea how to write a WPT for simulating user input. Webdriver? Open to suggestions here.
* Support for textarea (should be trivial, probably worth filing another issue)

#7320
#7004

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7323)
<!-- Reviewable:end -->
@jdm jdm closed this Feb 17, 2016
jrmuizel pushed a commit to jrmuizel/gecko-cinnabar that referenced this issue Jun 12, 2017
…(from samfoo:input-maxlength); r=jdm

This implements maxlength [as described by whatwg](https://html.spec.whatwg.org/multipage/forms.html#dom-input-maxlength) for input elements.

Remaining work:
* WPT test - I have no idea how to write a WPT for simulating user input. Webdriver? Open to suggestions here.
* Support for textarea (should be trivial, probably worth filing another issue)

servo/servo#7320
servo/servo#7004

Source-Repo: https://github.com/servo/servo
Source-Revision: fc3e950052b6cc580dc32fc03d978fad97b49ba8
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this issue Oct 1, 2019
…(from samfoo:input-maxlength); r=jdm

This implements maxlength [as described by whatwg](https://html.spec.whatwg.org/multipage/forms.html#dom-input-maxlength) for input elements.

Remaining work:
* WPT test - I have no idea how to write a WPT for simulating user input. Webdriver? Open to suggestions here.
* Support for textarea (should be trivial, probably worth filing another issue)

servo/servo#7320
servo/servo#7004

Source-Repo: https://github.com/servo/servo
Source-Revision: fc3e950052b6cc580dc32fc03d978fad97b49ba8

UltraBlame original commit: b43c7b497f1c48fcd2887144ff51f98b5f2df619
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this issue Oct 1, 2019
…(from samfoo:input-maxlength); r=jdm

This implements maxlength [as described by whatwg](https://html.spec.whatwg.org/multipage/forms.html#dom-input-maxlength) for input elements.

Remaining work:
* WPT test - I have no idea how to write a WPT for simulating user input. Webdriver? Open to suggestions here.
* Support for textarea (should be trivial, probably worth filing another issue)

servo/servo#7320
servo/servo#7004

Source-Repo: https://github.com/servo/servo
Source-Revision: fc3e950052b6cc580dc32fc03d978fad97b49ba8

UltraBlame original commit: b43c7b497f1c48fcd2887144ff51f98b5f2df619
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this issue Oct 1, 2019
…(from samfoo:input-maxlength); r=jdm

This implements maxlength [as described by whatwg](https://html.spec.whatwg.org/multipage/forms.html#dom-input-maxlength) for input elements.

Remaining work:
* WPT test - I have no idea how to write a WPT for simulating user input. Webdriver? Open to suggestions here.
* Support for textarea (should be trivial, probably worth filing another issue)

servo/servo#7320
servo/servo#7004

Source-Repo: https://github.com/servo/servo
Source-Revision: fc3e950052b6cc580dc32fc03d978fad97b49ba8

UltraBlame original commit: b43c7b497f1c48fcd2887144ff51f98b5f2df619
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.