Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make dom_struct derive HeapSizeOf #7357

Closed
jdm opened this issue Aug 25, 2015 · 3 comments
Closed

Make dom_struct derive HeapSizeOf #7357

jdm opened this issue Aug 25, 2015 · 3 comments
Labels
A-plugins C-assigned E-easy

Comments

@jdm
Copy link
Member

@jdm jdm commented Aug 25, 2015

Currently all of our DOM types have #[dom_struct] and #[derive(HeapSizeOf)]. We should make #[dom_struct] add that annotation automatically instead.

Code: expand_dom_struct in components/plugins/jstraceable.rs
@jxs
Copy link
Contributor

@jxs jxs commented Aug 25, 2015

i can take this one
@jdm
Copy link
Member Author

@jdm jdm commented Aug 25, 2015

Ok!
@jdm jdm added the C-assigned label Aug 25, 2015
jxs added a commit to jxs/servo that referenced this issue Aug 25, 2015
@jxs
make dom_struct derive HeapSizeOf,
f7b2ba6 
closes servo#7357
@jxs jxs mentioned this issue Aug 25, 2015
Merged
jxs added a commit to jxs/servo that referenced this issue Aug 25, 2015
@jxs
make dom_struct derive HeapSizeOf,
ee2636e 
closes servo#7357
@boghison
Copy link
Contributor

@boghison boghison commented Aug 25, 2015

Are you kidding me?
jxs added a commit to jxs/servo that referenced this issue Aug 25, 2015
@jxs
make dom_struct derive HeapSizeOf,
d2e001c 
closes servo#7357
jxs added a commit to jxs/servo that referenced this issue Aug 26, 2015
@jxs
make dom_struct derive HeapSizeOf,
9d0d415 
closes servo#7357
jxs added a commit to jxs/servo that referenced this issue Aug 26, 2015
@jxs
make dom_struct derive HeapSizeOf,
f21d5f5 
closes servo#7357
jxs added a commit to jxs/servo that referenced this issue Aug 26, 2015
@jxs
make dom_struct derive HeapSizeOf,
677b844 
closes servo#7357
jxs added a commit to jxs/servo that referenced this issue Aug 27, 2015
@jxs
make dom_struct derive HeapSizeOf,
fd87c8c 
closes servo#7357
bors-servo pushed a commit that referenced this issue Aug 27, 2015
bors-servo
Auto merge of #7361 - jxs:master, r=Ms2ger
Loading status checks…
532fd19 
make dom_struct derive HeapSizeOf

closes #7357

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7361)
<!-- Reviewable:end -->
josiahdaniels added a commit to josiahdaniels/servo that referenced this issue Sep 28, 2015
@jxs @josiahdaniels
make dom_struct derive HeapSizeOf,
72f30d6 
closes servo#7357
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-plugins C-assigned E-easy
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

make dom_struct derive HeapSizeOf
3 participants
@jdm @jxs @boghison
You can’t perform that action at this time.