Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upCheck for multiple import blocks separated by whitespace #7381
Labels
Comments
|
I'd like to take this. |
|
@nerith Please do! |
|
@nerith Still working on this? |
nerith
added a commit
to nerith/servo
that referenced
this issue
Sep 17, 2015
This enables flagging multiple import blocks separated by whitespace as errors. Fixes servo#7381.
nerith
added a commit
to nerith/servo
that referenced
this issue
Sep 19, 2015
This enables flagging multiple import blocks separated by whitespace as errors. Fixes servo#7381.
bors-servo
pushed a commit
that referenced
this issue
Sep 19, 2015
Check for multiple import blocks separated by whitespace Fixes #7381. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7662) <!-- Reviewable:end -->
josiahdaniels
added a commit
to josiahdaniels/servo
that referenced
this issue
Sep 28, 2015
This enables flagging multiple import blocks separated by whitespace as errors. Fixes servo#7381.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Following the recommendation in https://groups.google.com/forum/#!topic/mozilla.dev.servo/FoiIS5zWujE , we'd like to merge all of our import blocks together and report any unmerged ones as errors. This should be possible if we store a boolean values for "last line was a use statement", "encountered whitespace following a use statement", and when encountering a use statement we can report an error if the last boolean is true.
Code: python/tidy.py