Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intermittent ipc-channel assertion in /html/semantics/embedded-content/the-canvas-element/size.attributes.setAttribute.hex.html and size.attributes.setAttribute.zero.html #7422

Closed
jdm opened this issue Aug 28, 2015 · 3 comments

Comments

@jdm
Copy link
Member

@jdm jdm commented Aug 28, 2015

 7:10.64 TEST_START: Thread-TestrunnerManager-1 /html/semantics/embedded-content/the-canvas-element/size.attributes.setAttribute.hex.html
 7:10.74 PROCESS_OUTPUT: Thread-TestrunnerManager-1 (pid:47571) Full command: /Users/servo/buildbot/slave/mac1/build/target/release/servo --cpu --hard-fail -u Servo/wptrunner -z http://localhost:8000/html/semantics/embedded-content/the-canvas-element/size.attributes.setAttribute.hex.html --user-stylesheet /Users/servo/buildbot/slave/mac1/build/resources/ahem.css
(pid:47571) "thread 'CanvasTask' panicked at 'assertion failed: mach_sys::vm_remap(mach_task_self(), &mut address, self.length, 0, 1,"
 7:10.74 PROCESS_OUTPUT: Thread-TestrunnerManager-1 (pid:47571) "                   mach_task_self(), self.ptr as usize, 0, &mut 0, &mut 0,"
 7:10.74 PROCESS_OUTPUT: Thread-TestrunnerManager-1 (pid:47571) "                   VM_INHERIT_SHARE) == KERN_SUCCESS', /Users/servo/.cargo/git/checkouts/ipc-channel-d95a23d1f1577bfc/master/platform/macos/mod.rs:649"
 7:10.74 PROCESS_OUTPUT: Thread-TestrunnerManager-1 (pid:47571) "stack backtrace:"
 7:10.74 PROCESS_OUTPUT: Thread-TestrunnerManager-1 (pid:47571) "   1:        0x10d7d3810 - sys::backtrace::write::h095d0f07f92e7e3eYts"
 7:10.74 PROCESS_OUTPUT: Thread-TestrunnerManager-1 (pid:47571) "   2:        0x10d7d6be3 - panicking::on_panic::h5f4115f30a6b4860Z7w"
 7:10.74 PROCESS_OUTPUT: Thread-TestrunnerManager-1 (pid:47571) "   3:        0x10d7c5ba2 - rt::unwind::begin_unwind_inner::h7c54671eea5e313e0Cw"
 7:10.74 PROCESS_OUTPUT: Thread-TestrunnerManager-1 (pid:47571) "   4:        0x10cf5af41 - rt::unwind::begin_unwind::h7029542613236367883"
 7:10.74 PROCESS_OUTPUT: Thread-TestrunnerManager-1 (pid:47571) "   5:        0x10cf5a187 - platform::macos::MachSharedMemory.Clone::clone::h321da69eff6a204e8Ik"
 7:10.74 PROCESS_OUTPUT: Thread-TestrunnerManager-1 (pid:47571) "   6:        0x10cd7f206 - ipc::IpcSender<T>::send::h14285844546306345181"
 7:10.74 PROCESS_OUTPUT: Thread-TestrunnerManager-1 (pid:47571) "   7:        0x10cd72edd - canvas_paint_task::CanvasPaintTask<'a>::start::closure.18311"
 7:10.74 PROCESS_OUTPUT: Thread-TestrunnerManager-1 (pid:47571) "   8:        0x10cd728a0 - boxed::F.FnBox<A>::call_box::h17394894645085663790"
 7:10.74 PROCESS_OUTPUT: Thread-TestrunnerManager-1 (pid:47571) "   9:        0x10cd72192 - rt::unwind::try::try_fn::h10423060297511634746"
 7:10.74 PROCESS_OUTPUT: Thread-TestrunnerManager-1 (pid:47571) "  10:        0x10d7d65b8 - __rust_try"
 7:10.74 PROCESS_OUTPUT: Thread-TestrunnerManager-1 (pid:47571) "  11:        0x10d7d2210 - rt::unwind::try::inner_try::h39d984f71e9cc780Tyw"
 7:10.74 PROCESS_OUTPUT: Thread-TestrunnerManager-1 (pid:47571) "  12:        0x10cd72347 - boxed::F.FnBox<A>::call_box::h15094826673888591186"
 7:10.74 PROCESS_OUTPUT: Thread-TestrunnerManager-1 (pid:47571) "  13:        0x10d7d58ad - sys::thread::Thread::new::thread_start::h999b3790b6d4b23deXv"
 7:10.74 PROCESS_OUTPUT: Thread-TestrunnerManager-1 (pid:47571) "  14:     0x7fff8cbf6267 - _pthread_body"
 7:10.74 PROCESS_OUTPUT: Thread-TestrunnerManager-1 (pid:47571) "  15:     0x7fff8cbf61e4 - _pthread_start"
@jdm
Copy link
Member Author

@jdm jdm commented Aug 28, 2015

@pcwalton This is an assertion failure in ipc-channel.

@jdm jdm added the P-mac label Aug 28, 2015
@jdm jdm changed the title Intermittent crash in /html/semantics/embedded-content/the-canvas-element/size.attributes.setAttribute.hex.html Intermittent ipc-channel assertion in /html/semantics/embedded-content/the-canvas-element/size.attributes.setAttribute.hex.html Sep 2, 2015
@jdm
Copy link
Member Author

@jdm jdm commented Sep 4, 2015

@pcwalton This is starting to strike more often. It would be nice if you could spend some time investigating it.

@jdm
Copy link
Member Author

@jdm jdm commented Sep 18, 2015

Easily reproducible for me with ./mach test-wpt /2dcontext/fill-and-stroke-styles/2d.pattern.basic.zerocanvas.html --debugger=lldb and breaking on rust_panic.

@jdm jdm changed the title Intermittent ipc-channel assertion in /html/semantics/embedded-content/the-canvas-element/size.attributes.setAttribute.hex.html Intermittent ipc-channel assertion in /html/semantics/embedded-content/the-canvas-element/size.attributes.setAttribute.hex.html and size.attributes.setAttribute.zero.html Sep 24, 2015
pcwalton added a commit to servo/ipc-channel that referenced this issue Sep 30, 2015
`MachSharedMemory::clone()` and `MachSharedMemory::deref()`.

Part of the fix for servo/servo#7422.
pcwalton added a commit to pcwalton/servo that referenced this issue Sep 30, 2015
incorporate the fix for zero-sized shmem on Mac.

Depends on servo/rust-azure#201 and pcwalton/ipc-channel#10.

Closes servo#7422.
pcwalton added a commit to pcwalton/servo that referenced this issue Oct 1, 2015
incorporate the fix for zero-sized shmem on Mac.

Depends on servo/rust-azure#201 and pcwalton/ipc-channel#10.

Closes servo#7422.
bors-servo pushed a commit that referenced this issue Oct 1, 2015
Handle zero-sized source surfaces properly, and upgrade `ipc-channel` to incorporate the fix for zero-sized shmem on Mac.

Depends on servo/rust-azure#201 and pcwalton/ipc-channel#10.

Closes #7422.

r? @mbrubeck (don't r+ until the upstream dependencies have landed)

cc @jdm

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7802)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.